Repository navigation
[None][test] Remove 87 closed-bug waive entries for main - #20786
Conversation
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update integration test waivers tests/integration/test_lists/waives.txt |
The list adds and removes skips for selected model, serving, visual-generation, hardware-specific, accuracy, and performance tests. It updates entries across several hardware platforms and model configurations. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Merge Risk: 
698c1
-
The waiver changes have no additional confirmed issue in the supplied evidence. Confirm the latest CI results and address the previously reported GPTOSS coverage gap before merging.
Pre-merge checks: 
-
Check name Status Explanation Resolution Description check The description clearly explains the automated un-waive operation and lists the affected closed bugs and test entries, but it does not follow the repository template. It omits the required Description… Add the required Description section with the issue and solution, add a Test Coverage section that states the relevant validation or CI coverage, and include the PR Checklist with applicable items reviewed and checked. -
Check name Status Explanation Title check The title clearly identifies the test-related cleanup and removal of 87 closed-bug waive entries from main. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
-
Full details: Description check
-
Explanation
The description clearly explains the automated un-waive operation and lists the affected closed bugs and test entries, but it does not follow the repository template. It omits the required Description, Test Coverage, and PR Checklist sections.
Resolution
Add the required Description section with the issue and solution, add a Test Coverage section that states the relevant validation or CI coverage, and include the PR Checklist with applicable items reviewed and checked.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
/bot run |
|
PR_Github #79743 [ run ] triggered by Bot. Commit: |
crazydemo
left a comment
crazydemo
left a comment
There was a problem hiding this comment.
Review summary - Approve
Reviewed the full diff; no blocking or major issues found.
Automated review by NVCortex Lite, run by @crazydemo.
|
PR_Github #79743 [ run ] completed with state
|
Closed bug(s): 5580781, 5596343, 6295740, 6313072, 6327718, 6428124, 6432818, 6566768, 6581067, 6605819, 6624972, 6641268, 6644462, 6649384, 6649739, 6672360, 6690084, 6700707, 6726626, 6727262, 6731978, 6762288, 6782589, 6792615, 6813020, 6818106, 6818710, 6836096, 6836305, 6836306, 6838023, 6842831, 6843482, 6844164, 6859731, 6859934 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_UPDATE_WAIVES/120/ Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
f98c618 to
4562781
Compare
|
/bot run |
|
PR_Github #79846 [ run ] triggered by Bot. Commit: |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
PR_Github #79846 [ run ] completed with state
|
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run |
|
PR_Github #80017 [ run ] triggered by Bot. Commit: |
LarryXFly
left a comment
LarryXFly
left a comment
There was a problem hiding this comment.
Automated review by NVCortex Lite, run by @LarryXFly.
LarryXFly
left a comment
LarryXFly
left a comment
There was a problem hiding this comment.
Approve (non-blocking)
Approving so this isn't blocked on me — see the comments above; non-blocking, please address what you agree with before merging.
Automated review by NVCortex Lite, run by @LarryXFly.
|
PR_Github #80017 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #80319 [ run ] triggered by Bot. Commit: |
|
PR_Github #80319 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #80415 [ run ] triggered by Bot. Commit: |
|
PR_Github #80415 [ run ] completed with state
|
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #80497 [ run ] triggered by Bot. Commit: |
|
PR_Github #80497 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #80557 [ run ] triggered by Bot. Commit: |
|
PR_Github #80557 [ run ] completed with state |
Auto-generated Un-waive PR
Created by: TensorRT LLM CI (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_UPDATE_WAIVES/120/
Closed bug(s) un-waived: 5580781, 5596343, 6295740, 6313072, 6327718, 6428124, 6432818, 6566768, 6581067, 6605819, 6624972, 6641268, 6644462, 6649384, 6649739, 6672360, 6690084, 6700707, 6726626, 6727262, 6731978, 6762288, 6782589, 6792615, 6813020, 6818106, 6818710, 6836096, 6836305, 6836306, 6838023, 6842831, 6843482, 6844164, 6859731, 6859934
Waive entries removed
This PR was auto-generated by TensorRT LLM CI. Please review before merging.
Dev Engineer Review
tests/integration/test_lists/waives.txt. It removes some existingSKIPentries and adds three new waiver entries.QA Engineer Review
Per-File QA Perspective
tests/integration/test_lists/waives.txt: Verify the PR-specific removed and added selectors, including the new skips, and investigate the failed CI pipelines. The checked-out merge diff does not isolate the PR’s full change.