Repository navigation
Conversation
urm's sw-dl-triton-generic-local has refused anonymous reads (HTTP 401) since 2026-10-27, and install_base.sh downloads Boost from it whenever GITHUB_MIRROR is set, as it is in every CI image build. So every devel image build now fails. Download the same file from that repository on artifactory.nvidia.com, which serves it to anonymous reads. Its SHA-256 matches the boost.io release. Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com>
|
/bot run --stage-list "Build-Docker-Images" |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update mirrored Boost archive host docker/common/install_base.sh |
The mirror branch’s Boost archive URL now uses artifactory.nvidia.com instead of urm.nvidia.com. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: tburt-nv
Merge Risk: 
f0d90
-
The mirror URL update is limited in scope, with no identified merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the infrastructure change: downloading Boost from AWS Artifactory. Description check The description explains the issue, solution, impact, and validation plan. It includes the required Description, Test Coverage, and PR Checklist sections, with the checklist marked as reviewed. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #80978 [ run ] triggered by Bot. Commit: |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #80978 [ run ] completed with state |
Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com> (cherry picked from commit eb6fc51) Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com> (cherry picked from commit eb6fc51) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com> (cherry picked from commit eb6fc51) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com> (cherry picked from commit eb6fc51) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Sharabesh Jayaraman <338298191+sharabeshj-nvda@users.noreply.github.com> (cherry picked from commit eb6fc51) Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Description
Download Boost in the CI image builds from
sw-dl-triton-generic-localon artifactory.nvidia.com (AWS Artifactory) instead of the same repository on urm. Only the host inBOOST_URLindocker/common/install_base.shchanges. Builds withoutGITHUB_MIRRORstill download Boost from archives.boost.io.Why:
sw-dl-triton-generic-localwith HTTP 401.install_base.shdownloads Boost from there wheneverGITHUB_MIRRORis set, which every CI image build does, so every image build fails in the devel stage's firstRUNwithUsername/Password Authentication Failed.BuildDockerImages build 177 failed this way in all 14 attempts, on x86_64 and SBSA. Main's nightly image build, BuildDockerImages build 176, earlier the same day, still downloaded the file.4b2136f98bdd1f5857f1c3dea9ac2018effe65286cf251534b6ae20cc45e1847, the checksum boost.io publishes forboost_1_80_0.tar.gz.sw-dl-triton-generic-local, on main and onrelease/1.3. The image builds' other urm downloads still work: BuildDockerImages build 177 pulled its base images from urm before it failed, and thegithub-go-remotemirror thatGITHUB_MIRRORpoints to still answers anonymous reads.Sibling PR on
release/1.3: #21134. It makes the same change there, so the line reads the same on both branches.Impact:
wgetfollows. No credential, Jenkins or Dockerfile change is needed.Test Coverage
install_boost'swgetcommand, run anonymously against the new URL, followed the redirect and downloaded the 136,670,223-byte file with the SHA-256 above. The archive containsboost_1_80_0/boost/, the directoryinstall_boostinstalls./bot run --stage-list "Build-Docker-Images"builds every image family on x86_64 and SBSA: the CI images (Ubuntu and Rocky Linux), the internal release images, and the NGC devel and release images. Each runsinstall_base.sh. In eachmake …_pushstage's log,BOOST_URLshould be the artifactory.nvidia.com URL, andwgetshould report[136670223/136670223] -> "/tmp/boost.tar.gz". TheRegister NGC Image For Security Checkstage fails in pre-merge image builds whatever the images do (it failed in BuildDockerImages build 169, where every image built), so judge the run by itsmake …_pushstages, not its overall result.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.🤖 Generated with Claude Code
Dev Engineer Review
When
GITHUB_MIRRORis set,BOOST_URLnow usesartifactory.nvidia.com. Without the mirror, it still usesarchives.boost.io. Both paths feed the existinginstall_boostfunction, which extracts Boost 1.80.0 and installs its headers. No other code changes are reported.The PR author reports that the Artifactory archive matches the expected size and SHA-256 checksum. The requested Docker image build has no reported outcome, so CI validation remains unconfirmed.
QA Engineer Review
No test changes.
Per-File QA Perspective
docker/common/install_base.sh: Verify Boost downloads in builds with and withoutGITHUB_MIRROR, and confirm that both paths install Boost 1.80.0 headers. The requested Docker image build has no reported result.