Repository navigation
Conversation
Signed-off-by: bvolpato <brunocvcunha@gmail.com>
Signed-off-by: bvolpato <brunocvcunha@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation. A parallel unittest process can exit unsuccessfully after its tests pass. With an empty last-failed cache, the wrapper's
--lfretry executes the entire passing workload again. A successful rerun can then hide the process failure. This wastes test execution and makes the CI result unreliable.Change. Give each parallel attempt and its serial retry a private pytest cache, and set
--lfnf=none. Pytest teardown removes the cache.Verified before/after. The reproduction injects a nonzero controller exit after a passing run with real pytest-xdist workers:
The regressions demonstrate failure preservation and avoided re-execution. Saved CI minutes and changes in failure frequency have not been measured. The original process failure still requires diagnosis.
Test Coverage
test_unittest_culprits.pywith actual pytest-xdist worker processes and actual sequential last-failed selection. Empty and stale caches preserve process failures, while a test that fails once can pass its targeted retry.cpu_onlyand is covered by the existingunittest/toolsCPU CI entry.git diff --checkpass. Jenkins and GPU workloads were not run locally.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.