Skip to content

[CI] Run the CMake integration test and the dynamics test suite - #5332

Open
mitchdz wants to merge 1 commit into
mainfrom
fix/validation-silent-skips
Open

[CI] Run the CMake integration test and the dynamics test suite#5332
mitchdz wants to merge 1 commit into
mainfrom
fix/validation-silent-skips

Conversation

@mitchdz

@mitchdz mitchdz commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Two more validation gaps found while auditing for checks that report success without testing anything.

test_cmake_find_package.sh never ran in any of the six jobs that invoke it. Installer validation did not copy the script into the test user's workdir, so validate_installation.sh reported "script not found" and skipped it. Release image validation found the script but had no cmake, so it skipped via the other branch of the same guard. Copy the script, and install cmake where it is missing. The script requires cmake 4.0, so it comes from pip on Ubuntu and from conda on ubi8, whose Python 3.6 cannot install a current cmake wheel.

The dynamics wheel check was a smoke test written inline in this workflow. Replace it with the repo's own dynamics suite, which is 95 tests rather than one assertion, is maintained alongside the code, and keeps test logic out of CI YAML.

Verified against the artifacts of validation run 33139965314. The CMake test passes in the release image, in an Ubuntu installer environment, and in a ubi8 installer environment. The dynamics suite reports 94 passed and 1 skipped, the skip being a torch integrator test that the wheel does not depend on.

Two more validation gaps found while auditing for checks that report
success without testing anything.

test_cmake_find_package.sh never ran in any of the six jobs that invoke
it. Installer validation did not copy the script into the test user's
workdir, so validate_installation.sh reported "script not found" and
skipped it. Release image validation found the script but had no cmake,
so it skipped via the other branch of the same guard. Copy the script,
and install cmake where it is missing. The script requires cmake 4.0, so
it comes from pip on Ubuntu and from conda on ubi8, whose Python 3.6
cannot install a current cmake wheel.

The dynamics wheel check was a smoke test written inline in this
workflow. Replace it with the repo's own dynamics suite, which is 95
tests rather than one assertion, is maintained alongside the code, and
keeps test logic out of CI YAML.

Verified against the artifacts of validation run 33139965314. The CMake
test passes in the release image, in an Ubuntu installer environment,
and in a ubi8 installer environment. The dynamics suite reports 94
passed and 1 skipped, the skip being a torch integrator test that the
wheel does not depend on.

Signed-off-by: mdzurick <mitch_dz@hotmail.com>
@github-actions github-actions Bot added the CI Anything related to CI label Aug 31, 2026

@1tnguyen 1tnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

CI Summary (push) — ✅ passed

Run #33422241765 · ✅ 7 · ⏩ 7 · ❌ 0 · ⛔ 0

Top-level jobs (14)
Job Result
binaries ⏩ skipped
build_and_test ✅ success
changes ✅ success
config_devdeps ✅ success
config_source_build ⏩ skipped
config_wheeldeps ✅ success
devdeps ✅ success
docker_image ⏩ skipped
gen_code_coverage ⏩ skipped
metadata ✅ success
python_metapackages ⏩ skipped
python_wheels ⏩ skipped
source_build ⏩ skipped
wheeldeps ✅ success
⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch
Job
binaries
config_source_build
docker_image
gen_code_coverage
python_metapackages
python_wheels
source_build
All sub-jobs (43) — every matrix leg, with links
Job Status Link
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) ✅ success view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python) ✅ success view
Build and test (amd64, llvm, openmpi) / Dev environment (Debug) ✅ success view
Build and test (amd64, llvm, openmpi) / Dev environment (Python) ✅ success view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug) ✅ success view
Build and test (arm64, llvm, openmpi) / Dev environment (Python) ✅ success view
CI Summary ❔ in_progress view
Check for stable CUDA-Q changes ✅ success view
Configure build (devdeps) ✅ success view
Configure build (source_build) ⏩ skipped view
Configure build (wheeldeps) ✅ success view
Create CUDA Quantum installer ⏩ skipped view
Create Docker images ⏩ skipped view
Create Python metapackages ⏩ skipped view
Create Python wheels ⏩ skipped view
Gen code coverage ⏩ skipped view
Load dependencies (amd64, gcc12) / Caching ✅ success view
Load dependencies (amd64, gcc12) / Finalize ✅ success view
Load dependencies (amd64, gcc12) / Metadata ✅ success view
Load dependencies (amd64, llvm) / Caching ✅ success view
Load dependencies (amd64, llvm) / Finalize ✅ success view
Load dependencies (amd64, llvm) / Metadata ✅ success view
Load dependencies (arm64, gcc12) / Caching ✅ success view
Load dependencies (arm64, gcc12) / Finalize ✅ success view
Load dependencies (arm64, gcc12) / Metadata ✅ success view
Load dependencies (arm64, llvm) / Caching ✅ success view
Load dependencies (arm64, llvm) / Finalize ✅ success view
Load dependencies (arm64, llvm) / Metadata ✅ success view
Load source build cache ⏩ skipped view
Load wheel dependencies (amd64, 12.6) / Caching ✅ success view
Load wheel dependencies (amd64, 12.6) / Finalize ✅ success view
Load wheel dependencies (amd64, 12.6) / Metadata ✅ success view
Load wheel dependencies (amd64, 13.0) / Caching ✅ success view
Load wheel dependencies (amd64, 13.0) / Finalize ✅ success view
Load wheel dependencies (amd64, 13.0) / Metadata ✅ success view
Load wheel dependencies (arm64, 12.6) / Caching ✅ success view
Load wheel dependencies (arm64, 12.6) / Finalize ✅ success view
Load wheel dependencies (arm64, 12.6) / Metadata ✅ success view
Load wheel dependencies (arm64, 13.0) / Caching ✅ success view
Load wheel dependencies (arm64, 13.0) / Finalize ✅ success view
Load wheel dependencies (arm64, 13.0) / Metadata ✅ success view
Prepare cache clean-up ❔ in_progress view
Retrieve PR info ✅ success view
✅ Required checks (6/6) — declared in .github/required-checks.yml for push
Required check Status Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug) ✅ success view
Build and test (amd64, llvm, openmpi) / Dev environment (Python) ✅ success view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug) ✅ success view
Build and test (arm64, llvm, openmpi) / Dev environment (Python) ✅ success view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) ✅ success view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python) ✅ success view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Anything related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants