Skip to content
This repository was archived by the owner on Jan 24, 2021. It is now read-only.
This repository was archived by the owner on Jan 24, 2021. It is now read-only.

Disposing of a custom Bootstrapper makes NancyHost fail silently #3005

Description

@Demiu

Description

Disposing of a Bootstrapper used in a NancyHost causes said host to eternally load pages. I know this is more of a user mistake, but Nancy should somehow notify that something went wrong instead of silently failing and loading forever, which hints more at a firewall or network interface issue rather than application issue. Perhaps it should return a 500 or throw an exception.

Steps to Reproduce

Just this below code + a smallest possible module with a Get for testing. I am using a custom bootstrapper here just as a possible use-case where this might occur

using (var bootstrapper = new MyBootstrapper(dependency)) {
    host = new NancyHost(bootstrapper, myUri);
    host.Start();
}
Console.ReadKey();

System Configuration

  • Nancy version: v2.0.0
  • Nancy host
    • Nancy.Hosting.Self
  • Environment (Operating system, version and so on): Win10 x64
  • .NET Framework version: .NET Framework 4.6.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions