Skip to content

Commit 9aa934b

Browse files
committed
compute: verified cells no longer mention unattributed sibling failures
1 parent e2b35a5 commit 9aa934b

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎shared/compute.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,7 @@ export function cellFor(
289289

290290
// Any success outranks failures: a combination that built once builds.
291291
if (entry.verified[key]?.some((verified) => sameLine(verified, toolchainVersion))) {
292-
const alsoFailed = entry.suspect?.[key]?.some((failed) => sameLine(failed, toolchainVersion));
293-
return { state: "verified", reason: alsoFailed ? "verified by CI (one other attempt failed)" : "verified by CI" };
292+
return { state: "verified", reason: "verified by CI" };
294293
}
295294
if (entry.failed?.[key]?.some((failed) => sameLine(failed, toolchainVersion))) {
296295
return { state: "unsupported", reason: "build failed in two independent CI runs" };

‎test/compute.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,11 @@ describe("failed builds", () => {
189189
});
190190

191191
it("a success outranks a sibling failure and only successes prove the CLI's Node.js support", () => {
192-
expect(cellFor(doc(), "@nativescript/android", "9.1.1", "jdk", "17")).toMatchObject({ state: "verified", reason: "verified by CI (one other attempt failed)" });
192+
expect(cellFor(doc(), "@nativescript/android", "9.1.1", "jdk", "17")).toMatchObject({ state: "verified", reason: "verified by CI" });
193193
expect(doc().packages["nativescript"].versions["9.1.1"].verified).toEqual({ node: ["24"] });
194194
expect(doc().packages["@nativescript/android"].versions["9.1.1"].failed).toEqual({ jdk: ["25"] });
195-
expect(doc().packages["@nativescript/android"].versions["9.1.1"].suspect).toEqual({ jdk: ["21", "17"] });
195+
// The JDK 17 failure is not attributed to JDK 17: another build of the release succeeded with it.
196+
expect(doc().packages["@nativescript/android"].versions["9.1.1"].suspect).toEqual({ jdk: ["21"] });
196197
});
197198
});
198199

0 commit comments

Comments
 (0)