fix(runtime): URL toJSON and value-aware searchParams.delete

WHATWG URL defines toJSON as the href serialization, so JSON.stringify(url)
yields the href string. The runtime's URL lacked it, which also kept a
module URL from being assignable to lib.dom's URL in typed code. It is
registered next to toString and shares its callback, so both return the
same serialization. types/ns-url.d.ts declares it; tsc against the DOM and
the non-DOM program stays clean, and the DOM program now assigns
pathToFileURL()'s result to the global URL type.

The searchParams wrapper that keeps a URL's query in sync forwarded only the
name to the native delete, so url.searchParams.delete(name, value) removed
every pair with that name. It now forwards the value whenever the caller
passed one, by arity, so an explicit undefined still reaches the native
coercion.

Author: edusperoni

NativeScript/runtime/URLImpl.cpp

@@ -93,6 +93,10 @@ v8::Local<v8::FunctionTemplate> URLImpl::GetCtor(v8::Isolate* isolate) {
   tmpl->Set(ToV8String(isolate, "toString"),
             v8::FunctionTemplate::New(isolate, &ToString));
 
+  // WHATWG defines toJSON as the href serialization, the same as toString.
+  tmpl->Set(ToV8String(isolate, "toJSON"),
+            v8::FunctionTemplate::New(isolate, &ToString));
+
   ctorTmpl->Set(ToV8String(isolate, "canParse"),
                 v8::FunctionTemplate::New(isolate, &CanParse));
 

NativeScript/runtime/js/blob-url.js

@@ -105,9 +105,15 @@ ObjectDefineProperty(URL.prototype, 'searchParams', {
                 writeBack(this);
             };
             params._delete = params.delete;
-            params.delete = function (name) {
+            params.delete = function (name, value) {
                 resync(this);
-                this._delete(name);
+                // An explicitly passed undefined must still reach the native
+                // coercion, so forward by arity rather than by value.
+                if (arguments.length > 1) {
+                    this._delete(name, value);
+                } else {
+                    this._delete(name);
+                }
                 writeBack(this);
             };
             params._set = params.set;

TestRunner/app/tests/URL.js

@@ -58,4 +58,11 @@ describe("URL", function () {
     expect(url.searchParams.get("q")).toBe("hello");
     expect(url.pathname).toBe("/some/path");
   });
+
+  it("serializes to JSON as its href", function () {
+    const url = new URL("https://x.test/a?b#c");
+    expect(url.toJSON()).toBe(url.href);
+    expect(JSON.stringify(url)).toBe(JSON.stringify(url.href));
+    expect(JSON.stringify({ u: url })).toBe(JSON.stringify({ u: url.href }));
+  });
 });

TestRunner/app/tests/UrlSearchParamsTests.js

@@ -146,4 +146,18 @@ describe("URL.searchParams caching", function () {
       expect(key).not.toBe("_searchParamsSource");
     }
   });
+
+  it("deletes only the matching pair when given a value", function () {
+    const url = new URL("https://x.test/?a=1&a=2");
+    url.searchParams.delete("a", "1");
+    expect(url.search).toBe("?a=2");
+    expect(url.searchParams.getAll("a")).toEqual(["2"]);
+  });
+
+  it("deletes every pair of the name when given no value", function () {
+    const url = new URL("https://x.test/?a=1&a=2");
+    url.searchParams.delete("a");
+    expect(url.search).toBe("");
+    expect(url.searchParams.getAll("a")).toEqual([]);
+  });
 });

types/ns-url.d.ts

@@ -22,6 +22,8 @@ declare module "ns:url" {
     username: string;
     /** Returns `href`. */
     toString(): string;
+    /** Returns `href`, so `JSON.stringify` serializes a URL as its href. */
+    toJSON(): string;
   }
 
   /** The WHATWG `URLSearchParams` surface the runtime implements. */