fix(options): validate the timeout option's value

The whitelist entry that skipped timeout's validation was a leftover of
the mocha-era pass-through list; timeout is a real declared option
(debug and device commands) and only coincidentally shared the name.
With the entry gone, a bare --timeout gets the same non-empty-value
staging warning as every other string option.

Author: edusperoni

lib/options.ts

@@ -15,7 +15,7 @@ export class Options {
 	private static DASHED_OPTION_REGEX = /(.+?)([A-Z])(.*)/;
 	private static NONDASHED_OPTION_REGEX = /(.+?)[-]([a-zA-Z])(.*)/;
 
-	private optionsWhiteList = ["timeout", "_", "$0"]; // These options shouldn't be validated
+	private optionsWhiteList = ["_", "$0"]; // yargs artifacts, not options
 	private globalOptions: IDictionary<IDashedOption> = {
 		log: { type: OptionType.String, hasSensitiveValue: false },
 		verbose: { type: OptionType.Boolean, hasSensitiveValue: false },

test/options.ts

@@ -137,6 +137,24 @@ describe("options", () => {
 			assert.isTrue(isExecutionStopped);
 		});
 
+		it("breaks execution when the timeout option has no value", () => {
+			process.argv.push("--timeout");
+			const options = createOptions(testInjector);
+			options.validateOptions();
+			process.argv.pop();
+			assert.isTrue(isExecutionStopped);
+		});
+
+		it("does not break execution when the timeout option has a value", () => {
+			process.argv.push("--timeout");
+			process.argv.push("500");
+			const options = createOptions(testInjector);
+			options.validateOptions();
+			process.argv.pop();
+			process.argv.pop();
+			assert.isFalse(isExecutionStopped);
+		});
+
 		it("breaks execution when valid option has value with spaces only", () => {
 			process.argv.push("--path");
 			process.argv.push("  ");