Commit 77e93b2
committed
fix(ffi): include BatchOps.mm in the V8 backend TU before HostObject.mm
CI (build job, "Build NativeScript" step) has been failing since iteration
5a's Stage 2 landed (2d44ebf): HostObject.mm references
nativescript::NsFillHostedSubtreeHostFunction (and, as of this iteration,
NsScanAttachedContentPresenceHostFunction), both defined in BatchOps.mm.
The Hermes TU (NativeApiJsi.mm) already includes BatchOps.mm immediately
before its own HostObject.mm include; the V8 TU (NativeApiV8.mm) never
got the matching include, so HostObject.mm's reference to those symbols
is undefined there -- "no member named 'NsFillHostedSubtreeHostFunction'
in namespace 'nativescript'". Invisible to every device-level gate because
the demo apps are Hermes-only; only surfaced in CI's V8-backend build.
Mirrors the Hermes ordering exactly (after ClassBuilder.mm, before
HostObject.mm) -- BatchOps.mm has no Hermes-specific dependencies (pure
jsi::Runtime/Value/Array + ObjC), so this is a mechanical, safe fix.1 parent 070dc04 commit 77e93b2
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
0 commit comments