Commit eec55cc
fix(ci): stop check_ffi_boundaries.sh false-positive on a comment string
check_ffi_boundaries.sh greps shared/ FFI sources for the literal string
"NativeApiJsi" (a proxy for JSI-Hermes coupling) -- it does not distinguish
comments from code. BatchOps.mm's header comment named that file directly,
tripping the check even though the file contains no facebook::jsi:: or
<jsi/ reference (it uses the same unqualified Runtime/Value/Array/
PropNameID names as every other shared/bridge TU, via the using-declarations
already in scope where it is textually included -- same pattern as
HostObject.mm, which the checker does not flag because it never spells out
the filename). No code change, no behavior change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E6M4WHJVVjazd1RQhi9aSb1 parent 2d44ebf commit eec55cc
1 file changed
Lines changed: 3 additions & 2 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
0 commit comments