Skip to content

Commit eec55cc

Browse files
DjDeveloperrclaude
andcommitted
fix(ci): stop check_ffi_boundaries.sh false-positive on a comment string
check_ffi_boundaries.sh greps shared/ FFI sources for the literal string "NativeApiJsi" (a proxy for JSI-Hermes coupling) -- it does not distinguish comments from code. BatchOps.mm's header comment named that file directly, tripping the check even though the file contains no facebook::jsi:: or <jsi/ reference (it uses the same unqualified Runtime/Value/Array/ PropNameID names as every other shared/bridge TU, via the using-declarations already in scope where it is textually included -- same pattern as HostObject.mm, which the checker does not flag because it never spells out the filename). No code change, no behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6M4WHJVVjazd1RQhi9aSb
1 parent 2d44ebf commit eec55cc

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

NativeScript/ffi/objc/shared/bridge/BatchOps.mm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
// per hosted view. Every decision mirrored below is pure geometry, cited
1010
// from the exact JS it replaces -- see each function's comment.
1111
//
12-
// Textually included by NativeApiJsi.mm (see the #include block near the
13-
// top of that file), same convention as every other shared bridge TU. Must
12+
// Textually included by the Hermes engine JSI translation unit (see the
13+
// #include block near the top of that file), same convention as every
14+
// other shared bridge TU. Must
1415
// appear AFTER host_objects/Object.mm (for NativeApiObjectHostObject) and
1516
// AFTER ObjCBridge.mm (for makeString) -- both already true at the include
1617
// site chosen (immediately before HostObject.mm's own #include).

0 commit comments

Comments
 (0)