-
-
Notifications
You must be signed in to change notification settings - Fork 561
style(theme): retint light theme to a cool neutral/slate palette #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -787,7 +787,7 @@ const Launcher: React.FC<LauncherProps> = ({ onStartMeeting, onOpenSettings, onO | |
| > | ||
| <path | ||
| d="M12 2C7.58172 2 4 5.58172 4 10V22L7 19L9.5 21.5L12 19L14.5 21.5L17 19L20 22V10C20 5.58172 16.4183 2 12 2Z" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. React Doctor · Your users download extra bytes for SVG d precision they can't see, so round it to 1 or 2 decimals. Fix → Round path, points, and transform decimals to 1 or 2 digits. The extra precision adds bytes with no visible difference. |
||
| fill={isLight ? '#48484A' : 'white'} | ||
| fill={isLight ? '#586878' : 'white'} | ||
| /> | ||
| <circle cx="9" cy="10" r="1.5" fill={isLight ? 'white' : 'black'} /> | ||
| <circle cx="15" cy="10" r="1.5" fill={isLight ? 'white' : 'black'} /> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -217,7 +217,7 @@ const MeetingChatOverlay: React.FC<MeetingChatOverlayProps> = ({ | |
| // Match the modes manager's `--mm-bg` exactly so the expanded chat | ||
| // card looks like the same dark grey surface. | ||
| const isLightTheme = useResolvedTheme() === 'light'; | ||
| const chatWindowBg = isLightTheme ? '#f9f9f9' : '#111111'; | ||
| const chatWindowBg = isLightTheme ? '#FAFAFA' : '#111111'; | ||
|
|
||
| // Submit initial query when overlay opens | ||
| useEffect(() => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. React Doctor ·
Fix → Return a cleanup function that stops the subscription or timer: |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Doctor ·
react-doctor/no-array-index-as-key(warning)Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like
key={item.id}, not the array index "idx".Fix → Use a stable id from the item, like
key={item.id}orkey={item.slug}. Index keys break when the list reorders or filters.Docs