Move None check for icon_path out of set_icon

Author: Natuworkguy

engine/core/__init__.py

@@ -4,6 +4,7 @@
 """
 Core engine systems and base components.
 """
+from pathlib import Path
 
 from importlib.machinery import ModuleSpec
 from types import ModuleType
@@ -404,7 +405,12 @@ def __init__(
         GP_BASE_PATH: str,
         cursor_visible: bool = True,
         fullscreen: bool = False,
-        icon_path: Optional[str] = None,
+        icon_path: Optional[
+            Union[
+                str,
+                Path
+            ]
+        ] = None,
         IS_EDITOR: bool = False,
     ) -> None:
         """
@@ -416,7 +422,7 @@ def __init__(
             height (int): Window height in pixels. Defaults to 600.
             cursor_visible (bool): Whether the mouse cursor is visible. Defaults to True.
             fullscreen (bool): Whether to start in fullscreen mode. Defaults to False.
-            icon_path (Optional[str]): Path to window icon image. Defaults to None.
+            icon_path (Optional[str | Path]): Path to window icon image. Defaults to None.
             IS_EDITOR (bool): Whether running in editor mode. Defaults to False.
             GP_BASE_PATH (str): Base path for game assets
 
@@ -443,7 +449,8 @@ def __init__(
         if not IS_EDITOR and sys.stdout is not None and sys.stdout.isatty():
             print(colorama.ansi.set_title(title), end="")
 
-        self.set_icon(icon_path)
+        if icon_path is not None:
+            self.set_icon(icon_path)
 
         pygame.mouse.set_visible(cursor_visible)
         self.clock: pygame.time.Clock = pygame.time.Clock()
@@ -528,23 +535,22 @@ def add_to_current_scene(self, entity: Entity) -> None:
 
         self.scenes[self.current_scene].add(entity)
 
-    def set_icon(self, icon_path: Optional[str]) -> None:
+    def set_icon(self, icon_path: Union[str, Path]) -> None:
         """
         Set the icon for the game window.
 
         Args:
-            icon_path (Optional[str]): The path to the icon file.
+            icon_path (str | Path): The path to the icon file.
         """
 
-        if icon_path is not None:
-            try:
-                image: pygame.Surface = pygame.image.load(
-                    os.path.join(self.GP_BASE_PATH, icon_path)
-                )
-                image = image.convert_alpha()
-                pygame.display.set_icon(image)
-            except (pygame.error, FileNotFoundError) as e:
-                logger(f"Error loading icon: {e}", status=LoggerStatus.WARNING)
+        try:
+            image: pygame.Surface = pygame.image.load(
+                os.path.join(self.GP_BASE_PATH, icon_path)
+            )
+            image = image.convert_alpha()
+            pygame.display.set_icon(image)
+        except (pygame.error, FileNotFoundError) as e:
+            logger(f"Error loading icon: {e}", status=LoggerStatus.WARNING)
 
     def updateall(self, dt: float, /, exclude: Optional[Scene] = None) -> None:
         """