Skip to content

Reset player when cuesheet changed #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NeoCoderMatrix86 merged 1 commit into from
Oct 16, 2026
Merged

Reset player when cuesheet changed #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AudioCuesheetEditor.End2EndTests/Models/AppBar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,13 @@ internal async Task OpenDisplayHotkeysAsync()
await MenuButton.ClickAsync();
await _page.GetByText("Hotkeys").ClickAsync();
}

internal async Task ResetCuesheetAsync()
{
await MenuButton.ClickAsync();
await _page.GetByRole(AriaRole.Menuitem, new() { Name = "Reset" }).ClickAsync();
await _page.GetByText("Reset cuesheet").ClickAsync();
await _page.GetByRole(AriaRole.Button, new() { Name = "Yes" }).ClickAsync();
}
}
}
12 changes: 12 additions & 0 deletions AudioCuesheetEditor.End2EndTests/Tests/Desktop/BasicTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,18 @@ public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
}

[TestMethod]
public async Task ResetCuesheet_ShouldResetAllCuesheetReferences_WhenResettingCuesheetAsync()
{
var bar = new AppBar(TestPage);
var detailView = new DetailView(TestPage);
await detailView.GotoAsync();
await detailView.AddAudiofileAsync();
await detailView.SetAudiofileInputFileAsync(0, "Kalimba.mp3");
await bar.ResetCuesheetAsync();
await Expect(TestPage.GetByRole(AriaRole.Tabpanel, new() { Name = "Detail view" })).ToMatchAriaSnapshotAsync("- group:\n - paragraph: \"--:--:--\"\n - slider \"Playback slider\" [disabled]: \"0\"\n - paragraph: \"--:--:--\"\n- group:\n - button \"Play\" [disabled]\n - group:\n - button \"Jump to previous track\" [disabled]\n - button \"Stop the current playback\" [disabled]\n - button \"Jump to next track\" [disabled]");
}

[TestMethod]
public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
{
Expand Down
12 changes: 12 additions & 0 deletions AudioCuesheetEditor.End2EndTests/Tests/Smartphone/BasicTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@ public async Task OpenSettings_ShouldDisplaySettings_WhenSelectingSettings()
await Expect(TestPage.GetByRole(AriaRole.Heading, new() { Name = "Settings" })).ToBeVisibleAsync();
}

[TestMethod]
public async Task ResetCuesheet_ShouldResetAllCuesheetReferences_WhenResettingCuesheetAsync()
{
var bar = new AppBar(TestPage);
var detailView = new DetailView(TestPage);
await detailView.GotoAsync();
await detailView.AddAudiofileAsync();
await detailView.SetAudiofileInputFileAsync(0, "Kalimba.mp3");
await bar.ResetCuesheetAsync();
await Expect(TestPage.GetByRole(AriaRole.Tabpanel, new() { Name = "Detail view" })).ToMatchAriaSnapshotAsync("- group:\n - paragraph: \"--:--:--\"\n - slider \"Playback slider\" [disabled]: \"0\"\n - paragraph: \"--:--:--\"\n- group:\n - button \"Play\" [disabled]\n - group:\n - button \"Jump to previous track\" [disabled]\n - button \"Stop the current playback\" [disabled]\n - button \"Jump to next track\" [disabled]");
}

[TestMethod]
public async Task ChangeLanguage_ShouldSwitchLanguage_WhenGermanIsSelected()
{
Expand Down
1 change: 1 addition & 0 deletions AudioCuesheetEditor/Services/Audio/PlaybackService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ void AudiofileManager_AudiofileChanged(object? sender, Audiofile audiofile)
void SessionStateContainer_CuesheetChanged(object? sender, EventArgs e)
{
_ = StopAsync();
CurrentPositionChanged?.Invoke();
}

public async Task PlayOrPauseAsync()
Expand Down
4 changes: 2 additions & 2 deletions AudioCuesheetEditor/Shared/AppBar.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ along with Foobar. If not, see
@if (DisplayReset)
{
<MudMenu Label="@_localizer["Reset"]">
<MudMenuItem Icon="@Icons.Material.Outlined.NotStarted" OnClick="ResetCuesheetClicked">@_localizer["Reset cuesheet"]</MudMenuItem>
<MudMenuItem Icon="@Icons.Material.Outlined.RestartAlt" OnClick="ResetApplicationClicked">@_localizer["Reset application"]</MudMenuItem>
<MudMenuItem Icon="@Icons.Material.Outlined.NotStarted" OnClick="ResetCuesheetClicked" aria-label="Reset cuesheet">@_localizer["Reset cuesheet"]</MudMenuItem>
<MudMenuItem Icon="@Icons.Material.Outlined.RestartAlt" OnClick="ResetApplicationClicked" aria-label="Reset application">@_localizer["Reset application"]</MudMenuItem>
</MudMenu>
}
</MudMenu>
Expand Down
Loading