Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Commit a261559

Browse files
aliciamatsumotoAlicia Matsumoto
andauthored
surface signal tags (#6165)
Co-authored-by: Alicia Matsumoto <amats@netflix.com>
1 parent b20489e commit a261559

2 files changed

Lines changed: 4 additions & 19 deletions

File tree

src/dispatch/case/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ class SignalRead(DispatchBase):
266266
external_id: str
267267
external_url: str | None = None
268268
workflow_instances: list[WorkflowInstanceRead] | None = []
269+
tags: list[TagRead] | None = []
269270

270271

271272
class SignalInstanceRead(DispatchBase):

src/dispatch/database/service.py

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
from fastapi import Depends, Query
99
from pydantic import StringConstraints
10-
from pydantic import ValidationError
1110
from pydantic import Json
1211
from six import string_types
1312
from sortedcontainers import SortedSet
@@ -721,24 +720,9 @@ def search_filter_sort_paginate(
721720
sort_spec = create_sort_spec(model, sort_by, descending)
722721
query = apply_sort(query, sort_spec)
723722

724-
except FieldNotFound as e:
725-
raise ValidationError(
726-
[
727-
{
728-
"msg": str(e),
729-
"loc": "filter",
730-
}
731-
]
732-
) from None
733-
except BadFilterFormat as e:
734-
raise ValidationError(
735-
[
736-
{
737-
"msg": str(e),
738-
"loc": "filter",
739-
}
740-
]
741-
) from None
723+
except (FieldNotFound, BadFilterFormat) as e:
724+
log.error(f"Error building or applying filters: {str(e)}")
725+
raise e
742726

743727
if items_per_page == -1:
744728
items_per_page = None

0 commit comments

Comments
 (0)