Skip to content

Commit 3f52516

Browse files
committed
fix: improve error handling for file closure in CPU and memory usage functions
1 parent 4a89220 commit 3f52516

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

internal/agent/sysmetrics_linux.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ func readCPUUsageInstant() float64 {
4040
klog.V(4).Infof("Failed to open /proc/stat: %v", err)
4141
return 0
4242
}
43-
defer f.Close()
43+
defer func() {
44+
if closeErr := f.Close(); closeErr != nil {
45+
klog.V(4).Infof("Failed to close /proc/stat: %v", closeErr)
46+
}
47+
}()
4448

4549
scanner := bufio.NewScanner(f)
4650
for scanner.Scan() {
@@ -78,7 +82,11 @@ func readMemInfo() (int64, int64) {
7882
klog.V(4).Infof("Failed to open /proc/meminfo: %v", err)
7983
return 0, 0
8084
}
81-
defer f.Close()
85+
defer func() {
86+
if closeErr := f.Close(); closeErr != nil {
87+
klog.V(4).Infof("Failed to close /proc/meminfo: %v", closeErr)
88+
}
89+
}()
8290

8391
var totalKb, availableKb int64
8492
scanner := bufio.NewScanner(f)

0 commit comments

Comments
 (0)