Skip to content

Commit e308276

Browse files
andystimeclaude
andcommitted
Fix uninstall.sh to show actual unregister command output
- Remove output suppression (2>/dev/null) so users see real messages - Remove misleading "Agent unregistered from server" message - Let ggo command output speak for itself (shows "Not registered" or success) - Only show warnings if unregister actually fails (non-zero exit) This fixes the issue where uninstall claimed successful unregistration even when the agent was never registered, which was confusing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent ea5d7a5 commit e308276

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

scripts/uninstall.sh

100644100755
Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -299,22 +299,24 @@ unregister_from_server() {
299299
info "Agent config found in root directory, using sudo for unregistration"
300300
fi
301301

302-
# Run unregister command
302+
# Run unregister command (don't suppress output so user can see what happened)
303303
local unregister_result=0
304304
if [ "${needs_sudo}" = "true" ]; then
305305
SUDO=$(get_sudo)
306306
if [ -n "${SUDO}" ]; then
307-
${SUDO} "${binary_path}" agent unregister --force 2>/dev/null || unregister_result=$?
307+
${SUDO} "${binary_path}" agent unregister --force || unregister_result=$?
308308
else
309309
warn "Sudo not available, attempting unregister without sudo (may fail)"
310-
"${binary_path}" agent unregister --force 2>/dev/null || unregister_result=$?
310+
"${binary_path}" agent unregister --force || unregister_result=$?
311311
fi
312312
else
313-
"${binary_path}" agent unregister --force 2>/dev/null || unregister_result=$?
313+
"${binary_path}" agent unregister --force || unregister_result=$?
314314
fi
315315

316+
# Check result - exit code 0 means command succeeded (either unregistered or was not registered)
316317
if [ ${unregister_result} -eq 0 ]; then
317-
info "Agent unregistered from server"
318+
# Success - either unregistered or wasn't registered, both are fine
319+
:
318320
else
319321
warn "Server unregistration failed (exit code: ${unregister_result})"
320322
warn "Local config will still be removed"

0 commit comments

Comments
 (0)