Skip to content

fix: round calibration deltas for display #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dibya0912 wants to merge 2 commits into from
Closed

fix: round calibration deltas for display #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6ded91
fix: round calibration deltas for display
Dibya0912 Sep 5, 2026
ce6fe33
Merge branch 'main' into fix/calibration-delta-precision
Nitjsefnie Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/components/calibration-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,30 @@ export function CalibrationPanel({ comparison }: CalibrationPanelProps) {
<div className="calibration-grid">
<section aria-labelledby="self-work-heading">
<h2 id="self-work-heading">Self-work sample · {comparison.selfWork.count} pairs</h2>
<p>Mean delta {formatSigned(comparison.selfWork.meanDelta)}</p>
<p>Median delta {formatSigned(comparison.selfWork.medianDelta)}</p>
<p title={String(comparison.selfWork.meanDelta)}>Mean delta {formatSigned(comparison.selfWork.meanDelta)}</p>
<p title={String(comparison.selfWork.medianDelta)}>Median delta {formatSigned(comparison.selfWork.medianDelta)}</p>
</section>
<section aria-labelledby="outsider-heading">
<h2 id="outsider-heading">Outsider settlement sample · {comparison.outsider.count} pairs</h2>
<p>Mean delta {formatSigned(comparison.outsider.meanDelta)}</p>
<p>Median delta {formatSigned(comparison.outsider.medianDelta)}</p>
<p title={String(comparison.outsider.meanDelta)}>Mean delta {formatSigned(comparison.outsider.meanDelta)}</p>
<p title={String(comparison.outsider.medianDelta)}>Median delta {formatSigned(comparison.outsider.medianDelta)}</p>
</section>
</div>
<p className="calibration-difference">Difference between means {formatSigned(comparison.differenceBetweenMeans)}</p>
<p className="calibration-difference" title={String(comparison.differenceBetweenMeans)}>Difference between means {formatSigned(comparison.differenceBetweenMeans)}</p>
</section>
);
}

const deltaFormatter = new Intl.NumberFormat("en-US", { maximumFractionDigits: 2 });

function formatSigned(value: number): string {
if (value > 0) {
return `+${value}`;
const magnitude = deltaFormatter.format(Math.abs(value));
let formatted = "0";
if (magnitude !== "0" && value > 0) {
formatted = `+${magnitude}`;
}
if (value < 0) {
return `−${Math.abs(value)}`;
if (magnitude !== "0" && value < 0) {
formatted = `−${magnitude}`;
}
return "0";
return formatted;
}
16 changes: 16 additions & 0 deletions tests/components/calibration-panel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@ import { describe, expect, it } from "vitest";
import { CalibrationPanel } from "@/components/calibration-panel";

describe("calibration comparison", () => {
it("rounds fractional deltas and preserves raw values without signed zero", () => {
render(
<CalibrationPanel
comparison={{
selfWork: { count: 7, meanDelta: -4 / 7, medianDelta: 0 },
outsider: { count: 3, meanDelta: 1 / 3, medianDelta: 1 },
differenceBetweenMeans: -0.001,
}}
/>,
);

expect(screen.getByTitle(String(-4 / 7))).toHaveTextContent("−0.57");
expect(screen.getByTitle(String(1 / 3))).toHaveTextContent("+0.33");
expect(screen.getByTitle("-0.001")).toHaveTextContent(/^Difference between means 0$/);
});

it("compares self-work samples against outsider settlements", () => {
render(
<CalibrationPanel
Expand Down