Merge pull request #16407 from noib3/fix/c-api-null-primop-doc

libexpr-c: allow null primop docs

Author: xokdvium

src/libexpr-c/nix_api_value.cc

@@ -121,7 +121,7 @@ PrimOp * nix_alloc_primop(
                     .name = name,
                     .args = {},
                     .arity = (size_t) arity,
-                    .doc = doc,
+                    .doc = doc ? std::optional<std::string>{doc} : std::nullopt,
                     .impl = std::bind(nix_c_primop_wrapper, fun, user_data, arity, _1, _2, _3, _4)};
         if (args)
             for (size_t i = 0; args[i]; i++)

src/libexpr-tests/nix_api_expr.cc

@@ -299,6 +299,16 @@ primop_square(void * user_data, nix_c_context * context, EvalState * state, nix_
     nix_init_int(context, ret, i * i);
 }
 
+TEST_F(nix_api_expr_test, nix_alloc_primop_without_doc)
+{
+    PrimOp * primop = nix_alloc_primop(ctx, primop_square, 1, "undocumented", nullptr, nullptr, nullptr);
+    assert_ctx_ok();
+    ASSERT_NE(nullptr, primop);
+
+    nix_gc_decref(ctx, primop);
+    assert_ctx_ok();
+}
+
 TEST_F(nix_api_expr_test, nix_expr_primop)
 {
     PrimOp * primop = nix_alloc_primop(