Make DerivationBuilder not require a Store - #16381
Open
amaanq wants to merge 4 commits into
Open
Conversation
amaanq
force-pushed
the
derivation-builder-no-store
branch
from
August 28, 2026 01:34
aad1ef7 to
b2c6128
Compare
Ericson2314
reviewed
Aug 28, 2026
Ericson2314
reviewed
Aug 28, 2026
amaanq
force-pushed
the
derivation-builder-no-store
branch
from
August 28, 2026 14:42
b2c6128 to
1bb9f30
Compare
amaanq
changed the title
registerOutputs and cleanupBuildDerivationBuilder not require a Store
amaanq
force-pushed
the
derivation-builder-no-store
branch
3 times, most recently
from
August 28, 2026 15:20
9e026da to
1fc6ad0
Compare
Ericson2314
reviewed
Aug 28, 2026
Ericson2314
reviewed
Aug 28, 2026
amaanq
force-pushed
the
derivation-builder-no-store
branch
from
August 28, 2026 16:59
1fc6ad0 to
5348b90
Compare
xokdvium
reviewed
Aug 28, 2026
amaanq
force-pushed
the
derivation-builder-no-store
branch
2 times, most recently
from
August 28, 2026 18:08
fc16bb4 to
da3a013
Compare
Ericson2314
reviewed
Aug 28, 2026
Ericson2314
reviewed
Aug 28, 2026
Co-authored-by: Amaan Qureshi <git@amaanq.com>
…s possible This is for FFI: we can make a `StoreDirConfig` with FFI, but we cannot realistically make a `Store` that way.
amaanq
force-pushed
the
derivation-builder-no-store
branch
from
August 28, 2026 19:47
da3a013 to
10ed25a
Compare
The hope is to make `DerivationBuilder` easier to use with much less of libnixstore. Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
derivation-builder-no-store
branch
from
August 28, 2026 19:52
10ed25a to
fdbf219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DerivationBuildercurrently does store work itself, registering outputs and cleaning up at the end of the build, which couples it to a fullStoreeven though building only needs the store layout. These commits move that responsibility to the caller and switch the builder toStoreDirConfigwhere possible, soDerivationBuilderno longer requires aStore.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.