libexpr-c: allow null primop docs - #16407
Open
noib3 wants to merge 1 commit into
Open
Conversation
Problem: `nix_alloc_primop` crashes when the doc pointer is null, despite the C API documenting it as optional. Solution: treat null as `std::nullopt` (and add a regression test).
noib3
force-pushed
the
fix/c-api-null-primop-doc
branch
from
August 31, 2026 18:15
7789045 to
53440e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
nix_alloc_primopcrashes when the doc pointer is null, despite the C API documenting it as optional.Solution: treat null as
std::nullopt(and add a regression test).Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.