davis: 5.3.0 -> 5.4.1

[Ramblurr]

https://github.com/tchapi/davis/releases/tag/v5.4.0

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[Limosine]

Works nicely on my server. nixpkgs-review also ran without errors.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 498277
Commit: 09cd37fc306caea957028cd10b923d21c4dc048f

---

x86_64-linux

✅ 1 package built:

• davis

[Ramblurr]

@Limosine thanks for the feedback. Could you please leave a github review on the PR? It will appease the nixpkgs bot and help us get noticed by a nixpkgs committer sooner.

https://github.com/NixOS/nixpkgs/pull/498277/changes -> Submit Review [green button] -> Approve -> Submit Review

[Limosine]

Thanks for the PR. LGTM.

[NickCao]

What about the new API_KEY envvar, do we need to update the nixos module for it?

[Ramblurr]

Hmm, nice catch. The release notes don't mention anything about an API_KEY.. can you clarify what it's used for and how it affects the nixos module?

[ameertaweel]

I'm not sure if the release notes got updated after you checked, but they mention the API key:

Add (limited) API endpoint by unkn0wnAPI^* in tchapi/davis#237

*: Removed @ before username to not mention them.

[ameertaweel]

Also, v5.4.1 was released. Can you please update the PR to use it?

[ameertaweel]

Regarding the API key, here are the docs for it:
https://github.com/tchapi/davis/blob/main/docs/api/README.md

As far as I understand, we can just pass it via services.davis.config. But then it would be visible in the Nix source. Maybe @NickCao was suggesting to add an option similar to services.davis.appSecretFile, like services.davis.apiKeyFile.

[Ramblurr]

Also, v5.4.1 was released. Can you please update the PR to use it?

Incoming...

As far as I understand, we can just pass it via services.davis.config. But then it would be visible in the Nix source. Maybe @NickCao was suggesting to add an option similar to services.davis.appSecretFile, like services.davis.apiKeyFile.

This isn't strictly necessary, the module already supports passing arbitrary config values as files using _secret

services.davis.config = {
...
  API_KEY._secret = config.my.api-key.file.path;
...
};

[ameertaweel]

Thanks for updating the PR to v5.4.1 @Ramblurr.

Also, I totally missed the _secret thing. But now I don't see any needed changes in the NixOS module.

@NickCao can you clarify what you meant?

[NickCao]

Thanks for updating the PR to v5.4.1 @Ramblurr.

Also, I totally missed the _secret thing. But now I don't see any needed changes in the NixOS module.

@NickCao can you clarify what you meant?

I'm just saying the upstream diff shows a new field API_KEY in the .env file, so it seems we don't have to do anything to support it. No change to the module is needed then.

[Ramblurr]

I couldn't ever attract a nix committer to this PR :( but anyways this is done over in #526607 thanks to the bot

[NickCao]

Superseded by #526607