Skip to content

go_1_14: 1.14 -> 1.14.1 - #84735

Closed
vladdy wants to merge 1 commit into
NixOS:masterfrom
vladdy:update-go
Closed

go_1_14: 1.14 -> 1.14.1#84735
vladdy wants to merge 1 commit into
NixOS:masterfrom
vladdy:update-go

Conversation

@vladdy

@vladdy vladdy commented Apr 8, 2020

Copy link
Copy Markdown
Contributor
Motivation for this change

New minor release https://github.com/golang/go/releases/tag/go1.14.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Apr 8, 2020
@ofborg
ofborg Bot requested review from Frostman, Mic92, cstrahan and kalbasit April 8, 2020 16:36
@ofborg ofborg Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 8, 2020
@Frostman

Frostman commented Apr 8, 2020

Copy link
Copy Markdown
Member

It was already merged into staging: #83689

@vladdy

vladdy commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

hm.. I guess I missed that somehow. Thanks for noticing!

@vladdy vladdy closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit
@Frostman Frostman Awaiting requested review from Frostman
@cstrahan cstrahan Awaiting requested review from cstrahan
@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladdy @Frostman