fix(web): portal global modals above wallet - #1528
Open
lrk1314 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request - Frontend
Description
Global configuration modals could render below the Hyperliquid Wallet panel because they were mounted inside page stacking contexts. This change portals global overlays to
document.bodyand gives modal types an explicit layer contract.Type of Change
Related Issues
No linked issue. Reproduced from the Settings and Traders configuration flows.
Changes Made
ModalPortaland layer constants: primary 100, nested 110, critical 120No exchange API, model API, credential persistence, or trading logic is changed.
Screenshots / Demo
Manual verification confirmed that model and exchange overlays cover the Hyperliquid Wallet panel. The overlay is a direct
document.bodychild with computedz-index: 100.Testing
Test Environment
Manual Testing
Automated verification:
npx tsc --noEmitnpm test: 9 test files, 130 tests passednpm run build: 2917 modules transformed successfullyInternationalization
Checklist
Code Quality
npm run lintgate without baseline formatting exclusionsTesting
Documentation
Git
devAdditional Notes
The local pre-commit formatter rewrites several complete legacy TSX files. This PR intentionally keeps a surgical 11-file, 131-addition/51-deletion diff and records the formatting limitation above.
By submitting this PR, I confirm: