Repository navigation
Commit 4f446f2
Let the on-device chain test skip when there is no Portal
The QUIC cases built their node inside runCatching, so with no Portal
the assumption failure that should have skipped them was caught as an
ordinary throwable: one case failed asserting on it, which is what
turned CI's device job red, and the other passed having tested
nothing. The node is now built before runCatching.
Reproduced and verified with CI's own command on API 31 and API 35
emulators with no Portal: 57 tests, none failing, 33 skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 9ca1589 commit 4f446f2
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
46 | | - | |
47 | | - | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| 57 | + | |
55 | 58 | | |
56 | | - | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
0 commit comments