Repository navigation
Commit ff8b3a8
committed
Verify a pinned certificate on the QUIC carrier
A node carrying `pin` was refused rather than carried without verification —
honest, and unusable. It now works on both carriers, and the refusal narrows to
the case that genuinely is not implemented: chain verification against an `sni`
name, which needs Android's trust store fed into the QUIC stack's TLS backend
and is a different order of work (D-20 splits the two for exactly this reason).
The comparison happens in the bridge, inside a BoringSSL custom verify callback,
against the SHA-256 of the leaf's DER encoding — the same value `pin=` carries
and the TLS carrier already compares. Constant time through CRYPTO_memcmp: a
short-circuiting comparison leaks how many leading bytes matched, and that a
forger would need a fresh handshake per byte makes it slow rather than
impossible. The chain is deliberately not consulted, because a pinned
certificate is commonly self-signed and checking the chain first would reject
the very certificate the pin names — the TLS carrier makes the same choice for
the same reason.
A pin crosses the JNI boundary as 32 bytes, and a wrong length is refused at
both ends rather than padded or truncated: either would produce a connection
verifying against something nobody asked for. One conversion from hex serves
both carriers, so they cannot disagree about what a pin is, and a pin built by
hand out of something that is not hex throws instead of translating quietly.
The device case reads the pin off the Portal's **own leaf over an independent
TLS connection** and hands it back, so a pass cannot be the client agreeing with
itself; it also establishes that this Portal serves one certificate on both
listeners, which was not previously known. Verified to fail: with the callback
not installed, `oneWrongNibbleStopsTheHandshake` reports "a QUIC connection
accepted a certificate the pin does not name".
Two diagnostics came out of getting this wrong first. A refused certificate ends
the handshake without ending the wait, so the failure arrived as a bare
"the peer did not complete the QUIC handshake in time" — it now carries whatever
the bridge last said, including the digest actually presented, because a
mismatch has two very different causes and they are indistinguishable without
it. And e2e-fakeip.sh published only TCP, so every QUIC connection to that
Portal timed out rather than being refused; a round of this work was spent
debugging that as a verification defect before the port mapping was the answer.1 parent e81721e commit ff8b3a8
11 files changed
Lines changed: 394 additions & 30 deletions
File tree
- app/src
- androidTest/kotlin/eu/nodepass/somewhere/quic
- main
- jni/quic
- kotlin/eu/nodepass/somewhere
- protocol/url
- quic
- ui/screens
- vpn
- res
- values-b+zh+Hans
- values-b+zh+Hant
- values
- test/kotlin/eu/nodepass/somewhere/protocol/url
- conformance/scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
| |||
127 | 130 | | |
128 | 131 | | |
129 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
130 | 143 | | |
131 | 144 | | |
132 | 145 | | |
| |||
450 | 463 | | |
451 | 464 | | |
452 | 465 | | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
453 | 522 | | |
454 | 523 | | |
455 | 524 | | |
| |||
492 | 561 | | |
493 | 562 | | |
494 | 563 | | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
495 | 571 | | |
496 | 572 | | |
497 | 573 | | |
| |||
614 | 690 | | |
615 | 691 | | |
616 | 692 | | |
617 | | - | |
| 693 | + | |
618 | 694 | | |
619 | 695 | | |
620 | 696 | | |
621 | | - | |
| 697 | + | |
622 | 698 | | |
623 | 699 | | |
624 | 700 | | |
| |||
630 | 706 | | |
631 | 707 | | |
632 | 708 | | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
633 | 718 | | |
634 | 719 | | |
635 | 720 | | |
| |||
643 | 728 | | |
644 | 729 | | |
645 | 730 | | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
646 | 736 | | |
647 | 737 | | |
648 | 738 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
56 | 82 | | |
57 | 83 | | |
58 | 84 | | |
| |||
0 commit comments