Repository navigation
login: pin discovery app-version as documented constant; explain no-Auth0 failure - #27
Merged
Merged
Conversation
…uth0 failure Live discovery probing (2026-07-19) showed Medtronic returns a different config per app-version string: 3.4 -> cumulus v11/no-Auth0, 3.6/3.7 -> v13/Auth0, 4.0 -> v2/no-Auth0. The version we send is therefore load-bearing, not cosmetic — bumping it to a higher-looking number drops onto a config with no Auth0 SSO URL and breaks login. Extract it to DISCOVERY_APP_VERSION with a comment recording this, and make the no-SSO-URL error name the version as the likely cause instead of failing opaquely. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Public-facing compatibility research finding. Medtronic's discovery endpoint returns a different config per app-version string — verified by fetching all of them unauthenticated (these are the same public configs the app requests on startup):
discover/android/XSo the
3.6in our discovery URL is load-bearing, not cosmetic: a future "bump to a newer number" would silently land on a no-Auth0 config and break login with an opaque error. This extracts it to aDISCOVERY_APP_VERSIONconstant with a comment recording the finding, and rewrites the no-SSO-URL error to name the version string as the likely cause. No behavioural change on the happy path (stillandroid/3.6).Related issue
Follows the auth-flow research on #12. No functional change to the working flow.
Type of change
How was this tested?
npm testpasses locally (42/42)npx tsc --noEmitpasses locallyThe version→config mapping was verified against live public discovery responses; no credentials or authenticated calls involved.
Upstream relationship
Checklist
Security
logindata.jsoncontent is included in this PR🤖 Generated with Claude Code