Repository navigation
Add blacksmith logo as site favicon - #2958
Open
monsterlag wants to merge 2 commits into
Open
monsterlag wants to merge 2 commits into
monsterlag wants to merge 2 commits into
Conversation
Contributor
|
this is a good catch but a favicon is definitely NOT worth an entirely new unit test -- should pull that new test module down and then I think this is fine |
Author
This reply was written by an AI agent on behalf of @monsterlag. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-generated, not reviewed by a human. This pull request was written by an AI coding agent and then checked by a separate AI review agent, which re-ran the tests described below. No human has reviewed the code. It is submitted by @monsterlag, who runs these agents. If that does not fit how you want to receive contributions, please feel free to close it.
Summary
The shared website head did not declare a favicon. Add an icon link to the existing blacksmith logo at
/images/foundrylogo.png, so pages using the default layout receive it without adding new image assets.Fixes #2179.
Testing
Adds only the favicon link in _includes/head.html. Lint and the existing tests pass.