[17.0][FIX] password_security: do not swallow the sign-up refusal - #1008
Closed
artemShelest wants to merge 1 commit into
Closed
artemShelest wants to merge 1 commit into
artemShelest wants to merge 1 commit into
Conversation
web_auth_signup wraps the parent in `except Exception`, which catches the
NotFound the core controller raises when sign-up is disabled and re-renders
the sign-up form for it. A database with invitation-only sign-up therefore
answers 200 at /web/signup with a working-looking form on it. Nothing is
actually open — the POST is refused and res.users.signup() still raises
"Signup is not allowed for uninvited users" — but the page reads exactly
like the failure, so anyone checking by eye reads it backwards.
Re-raise werkzeug's HTTP exceptions instead. The broad catch below it stays:
it is what turns the raw ValueError from _create_user_from_template
("Signup: no name or partner given for new user") into a rendered form, which
test_06_web_auth_signup_invalid_render covers.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ExBrmpp4Ea4H94FYroUVrN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn by the author. Nothing to review here.