Skip to content

[18.0][ADD] auth_user_role_saml - #929

Open
astirpe wants to merge 4 commits into
OCA:18.0from
astirpe:18_add_auth_user_role_saml
Open

[18.0][ADD] auth_user_role_saml#929
astirpe wants to merge 4 commits into
OCA:18.0from
astirpe:18_add_auth_user_role_saml

Conversation

@astirpe

@astirpe astirpe commented Apr 17, 2026

Copy link
Copy Markdown
Member

Depends on #928

@OCA-git-bot OCA-git-bot added series:18.0 mod:auth_user_role Module auth_user_role mod:auth_user_role_saml Module auth_user_role_saml and removed mod:auth_user_role Module auth_user_role labels Apr 17, 2026
@astirpe
astirpe force-pushed the 18_add_auth_user_role_saml branch 2 times, most recently from 3ea9800 to ecbc69b Compare April 20, 2026 07:53
@astirpe
astirpe marked this pull request as ready for review April 20, 2026 07:57
CasVissers-360ERP
CasVissers-360ERP approved these changes Apr 20, 2026
View reviewed changes

@CasVissers-360ERP CasVissers-360ERP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@astirpe
astirpe force-pushed the 18_add_auth_user_role_saml branch from ecbc69b to 3a831ad Compare May 6, 2026 14:31
@astirpe

astirpe commented May 8, 2026

Copy link
Copy Markdown
Member Author

@CasVissers-360ERP
In commit 42596d1 I added an extra safety check. If strict_sync is active, but the database has zero auth.user.role.mapping records configured, applying a strict sync would wipe all roles from every user who logs in via SAML. The last commit avoids it.
Do you agree?

@CasVissers-360ERP

CasVissers-360ERP commented May 9, 2026

Copy link
Copy Markdown
Contributor

@astirpe I agree.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 6, 2026
@astirpe astirpe mentioned this pull request Sep 17, 2026
Open
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:auth_user_role_saml Module auth_user_role_saml series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astirpe @CasVissers-360ERP @OCA-git-bot