Skip to content

Clarify FeatureExtraction JAR checksum warning - #333

Open
pollychen-lab wants to merge 1 commit into
OHDSI:developfrom
pollychen-lab:agent/jar-checksum-message
Open

pollychen-lab wants to merge 1 commit into
OHDSI:developfrom
pollychen-lab:agent/jar-checksum-message

Conversation

@pollychen-lab

Copy link
Copy Markdown

Summary

  • move the Java checksum mismatch warning into a small internal helper
  • expand the warning so Java developers know to update inst/csv/jarChecksum.txt after rebuilding the Java library
  • add a regression test that verifies the warning points to the checksum file and package maintenance script

Fixes #291

Testing

  • git diff --check
  • Not run: R CMD check / testthat suite because Rscript is not installed in this environment (/bin/bash: Rscript: command not found).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant