Skip to content

Fug in valueAsConcept features code - #338

Open
schuemie wants to merge 1 commit into
developfrom
issue337
Open

schuemie wants to merge 1 commit into
developfrom
issue337

Conversation

@schuemie

Copy link
Copy Markdown
Member

Fixes #337

Tested in my own environment.

Adding a unit test to avoid regression is non-trivial. It would ideally require specifying includedCovariateIds that are constructed, which depends on the data. Could be done specifically in Eunomia.

@ginberg

ginberg commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

hi @schuemie, thanks for catching these issues! Did you test with aggregated = FALSE?
It seems to me that for the aggregated case, we still need the WHERE. I have added a test here that fails

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants