Tidy compositional flash diagnostics - #7393
Conversation
Route diagnostics through OpmLog and make the generated phase and composition messages clearer.
|
jenkins build this please https://ci.opm-project.org/job/opm-simulators-PR-builder/10583/ |
GitPaean
added
the
manual:irrelevant
There was a problem hiding this comment.
🟡 Changes recommended
Default MPI logging drops diagnostics produced on non-root ranks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Routes compositional flash diagnostics through OpmLog with clearer phase and composition formatting.
Changes:
- Replaces direct console output with debug logging.
- Improves per-cell flash diagnostic messages.
File summaries
| File | Description |
|---|---|
opm/models/ptflash/flashintensivequantities.hh |
Updates flash diagnostic logging and formatting. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
jenkins build this please |
There was a problem hiding this comment.
🟡 Changes recommended
allRanksDebugLoggingEnabled() can throw at startup when FlashVerbosity is specified before the parameter is registered (early parameter pass).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
Enable Flow's existing per-rank debug logging and merger whenever flash diagnostics are requested. Document where flash verbosity is written and apply the project formatting to the diagnostic output.
|
jenkins build this please |
Route diagnostics through OpmLog and make the generated phase and composition messages clearer.