Skip to content

feat(chart): support helm templating in secret and service account names in redis-cluster - #1838

Open
dcernag wants to merge 2 commits into
OT-CONTAINER-KIT:mainfrom
dcernag:feat/redis-cluster-templating
Open

feat(chart): support helm templating in secret and service account names in redis-cluster#1838
dcernag wants to merge 2 commits into
OT-CONTAINER-KIT:mainfrom
dcernag:feat/redis-cluster-templating

Conversation

@dcernag

@dcernag dcernag commented Jul 8, 2026

Copy link
Copy Markdown

Description

This change wraps the secretName and serviceAccountName values in the tpl function within the RedisCluster CRD template.

Previously, these fields only accepted literal strings. By passing them through tpl, users can now define dynamic names in their values.yaml utilizing standard Helm context variables (e.g., {{ .Release.Name }}-redis-auth).

This is especially useful for deployments relying on dynamic release naming or automated CI/CD pipelines.

Fields updated to support templating:

  • kubernetesConfig.redisSecret.name
  • kubernetesConfig.redisSecret.key
  • TLS.secret
  • acl.secret.secretName
  • serviceAccountName

Fixes #ISSUE

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@dcernag
dcernag force-pushed the feat/redis-cluster-templating branch from 7eb84c7 to cbefa1f Compare July 8, 2026 22:16
@dcernag

dcernag commented Jul 9, 2026

Copy link
Copy Markdown
Author

thanks for reviewing @iamabhishek-dubey, it seems the CI jobs failed to start (and ofc i don't have access to re-trigger from fork haha)

Could you please help re-triggering?

@dcernag
dcernag force-pushed the feat/redis-cluster-templating branch from cbefa1f to c53e30f Compare July 13, 2026 15:50
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c501720). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage        ?   33.72%           
=======================================
  Files           ?       85           
  Lines           ?     7307           
  Branches        ?        0           
=======================================
  Hits            ?     2464           
  Misses          ?     4568           
  Partials        ?      275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dcernag dcernag changed the title feat(chart/redis-cluster): support helm templating in secret and service account names feat(chart): support helm templating in secret and service account names in redis-cluster Jul 17, 2026
@shubham-cmyk
shubham-cmyk force-pushed the feat/redis-cluster-templating branch 2 times, most recently from 170e4ba to 3b16658 Compare August 19, 2026 11:08
@shubham-cmyk

shubham-cmyk commented Aug 19, 2026

Copy link
Copy Markdown
Member

Thanks for the PR @dcernag can you approve the appVesrsion to : v0.26.0 and bump the version in Chart.yaml

shubham-cmyk
shubham-cmyk previously approved these changes Aug 19, 2026
@shubham-cmyk
shubham-cmyk force-pushed the feat/redis-cluster-templating branch from 3b16658 to e028ea3 Compare August 19, 2026 14:50
@dcernag

dcernag commented Aug 20, 2026

Copy link
Copy Markdown
Author

Thanks for the PR @dcernag can you approve the appVesrsion to : v0.26.0 and bump the version in Chart.yaml

Thanks @shubham-cmyk, was the second part of the comment intended for me? (just to make sure if you're waiting on something from my side)

edit: already did bump appVersion and version just in case ;)

@dcernag
dcernag dismissed stale reviews from iamabhishek-dubey and shubham-cmyk via e028ea3 August 20, 2026 18:17
@dcernag
dcernag force-pushed the feat/redis-cluster-templating branch 4 times, most recently from 210204f to febb7f2 Compare August 20, 2026 22:23
…mes in redis-cluster

Signed-off-by: Diego Cerna <11181621+dcernag@users.noreply.github.com>
Signed-off-by: Diego Cerna <11181621+dcernag@users.noreply.github.com>
@dcernag
dcernag force-pushed the feat/redis-cluster-templating branch from febb7f2 to 4bba0ff Compare August 24, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants