feat(chart): support helm templating in secret and service account names in redis-cluster - #1838
Open
dcernag wants to merge 2 commits into
Open
feat(chart): support helm templating in secret and service account names in redis-cluster#1838dcernag wants to merge 2 commits into
dcernag wants to merge 2 commits into
Conversation
dcernag
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
July 8, 2026 22:14
dcernag
force-pushed
the
feat/redis-cluster-templating
branch
from
July 8, 2026 22:16
7eb84c7 to
cbefa1f
Compare
iamabhishek-dubey
previously approved these changes
Jul 9, 2026
Author
|
thanks for reviewing @iamabhishek-dubey, it seems the CI jobs failed to start (and ofc i don't have access to re-trigger from fork haha) Could you please help re-triggering? |
dcernag
force-pushed
the
feat/redis-cluster-templating
branch
from
July 13, 2026 15:50
cbefa1f to
c53e30f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
=======================================
Coverage ? 33.72%
=======================================
Files ? 85
Lines ? 7307
Branches ? 0
=======================================
Hits ? 2464
Misses ? 4568
Partials ? 275 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shubham-cmyk
force-pushed
the
feat/redis-cluster-templating
branch
2 times, most recently
from
August 19, 2026 11:08
170e4ba to
3b16658
Compare
Member
shubham-cmyk
previously approved these changes
Aug 19, 2026
shubham-cmyk
force-pushed
the
feat/redis-cluster-templating
branch
from
August 19, 2026 14:50
3b16658 to
e028ea3
Compare
Author
Thanks @shubham-cmyk, was the second part of the comment intended for me? (just to make sure if you're waiting on something from my side) edit: already did bump appVersion and version just in case ;) |
dcernag
dismissed stale reviews from iamabhishek-dubey and shubham-cmyk
via
August 20, 2026 18:17
e028ea3
dcernag
force-pushed
the
feat/redis-cluster-templating
branch
4 times, most recently
from
August 20, 2026 22:23
210204f to
febb7f2
Compare
…mes in redis-cluster Signed-off-by: Diego Cerna <11181621+dcernag@users.noreply.github.com>
Signed-off-by: Diego Cerna <11181621+dcernag@users.noreply.github.com>
dcernag
force-pushed
the
feat/redis-cluster-templating
branch
from
August 24, 2026 21:18
febb7f2 to
4bba0ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change wraps the
secretNameandserviceAccountNamevalues in thetplfunction within the RedisCluster CRD template.Previously, these fields only accepted literal strings. By passing them through
tpl, users can now define dynamic names in theirvalues.yamlutilizing standard Helm context variables (e.g.,{{ .Release.Name }}-redis-auth).This is especially useful for deployments relying on dynamic release naming or automated CI/CD pipelines.
Fields updated to support templating:
kubernetesConfig.redisSecret.namekubernetesConfig.redisSecret.keyTLS.secretacl.secret.secretNameserviceAccountNameFixes #ISSUE
Type of change
Checklist
Additional Context