Repository navigation
ci: scan Swift code with CodeQL - #19
Merged
Merged
Conversation
Code scanning only covered Actions and Python. This workflow adds Swift, building the app and helper unsigned on macOS, and keeps the other two languages.
The CodeQL tracer runs xcodebuild under Rosetta, where the arm64 destination isn't offered. Packages are now fetched before tracing starts. CI jobs now get a read-only token, which CodeQL flagged.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code scanning ran through GitHub's default setup, which only covered Actions and Python. The app and the privileged helper are Swift, so most of the code that matters was never scanned.
This replaces the default setup with a workflow that runs the same Actions and Python analysis and adds Swift. The Swift job builds the app and helper unsigned on a macOS runner so CodeQL can trace the compiled code. The tracer runs xcodebuild under Rosetta, so the build targets a generic Mac, and packages are fetched before tracing starts. It runs on pull requests to main, on pushes to main and once a week.
The first scan flagged that CI jobs ran with the default token permissions, so CI now gets a read-only token.
The default setup has been switched off in the repository settings, because GitHub refuses results from a workflow while the default setup is on.