Skip to content

Commit 0929ba0

Browse files
committed
test: align provider approval contracts with structured questions
1 parent 512adad commit 0929ba0

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎crewcoder-agent/src/tests/acp-adapter.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,8 @@ describe("acp server", () => {
533533
"crewcoder/instructionPolicy": { method: "session/set_instruction_policy", version: 1, globalSources: ["codex-agents", "claude-md"], persisted: false },
534534
"crewcoder/sessionToolPolicy": { method: "session/set_tool_policy", version: 1, policies: ["hosted-text-only"] },
535535
"crewcoder/clientTools": { method: "session/set_client_tools", callMethod: "crewcoder/client_tool/call", version: 1, maxTools: 32 },
536-
"crewcoder/artifacts": CREWCODER_ARTIFACTS_META
536+
"crewcoder/artifacts": CREWCODER_ARTIFACTS_META,
537+
"crewcoder/questions": { version: 1, method: "_crewcoder/request_question" }
537538
});
538539
});
539540

‎crewcoder-agent/src/tests/codex-approval-question.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const provider: ProviderDefinition = {
1616
};
1717

1818
describe("native approval questions", () => {
19-
it.each(["accept", "acceptForSession", "decline", undefined])("shows only the reason and preserves decision %s", async (answer) => {
19+
it.each(["accept", "acceptForSession", "decline", undefined])("keeps the reason as title, includes permission detail, and preserves decision %s", async (answer) => {
2020
const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "crew-question-"));
2121
// Node runs this extensionless fixture on Windows as well as POSIX.
2222
process.env.CREWCODER_CODEX_PATH = process.execPath;
@@ -48,7 +48,9 @@ readline.createInterface({ input: process.stdin }).on("line", (line) => {
4848
expect(result.exitCode).toBe(0);
4949
expect(result.stdout).toBe(answer ?? "decline");
5050
expect(questions).toEqual([{
51+
kind: "permission",
5152
title: "May I run the focused checks?",
53+
detail: JSON.stringify({ command: "powershell.exe -Command " + "source code ".repeat(1000) }, null, 2),
5254
options: [
5355
{ label: "Allow once", value: "accept" },
5456
{ label: "Allow session", value: "acceptForSession" },

0 commit comments

Comments
 (0)