You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d41eff8
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: crewcoder-agent/AGENTS.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -246,6 +246,7 @@ Codex / OpenAI Responses:
246
246
- If successful Codex output leaks raw SSE `data:` lines, normalize it back into CrewCoder assistant JSON before returning.
247
247
- HTTP 200 does not prove a successful Codex turn: SSE `error`, `response.failed`, and `response.incomplete` events are terminal provider failures. A stream ending without assistant text, tool calls, or completion metadata is also a provider/protocol failure, never a successful `(empty Codex response)` placeholder.
248
248
- Codex primarily uses official app-server durable threads stored under CrewCoder's isolated Codex home. Persist only the encoded thread/contract identifier in `providerSessionIds.codex`; never auth tokens. Local app-server turns use its native workspace-write shell/patch capabilities, and provider-native approval requests must route through the active host interaction channel. When `useProviderNativeFileTools` is false for an ACP/SDK virtual filesystem, skip app-server entirely and use the direct Responses transport so built-in local shell/patch tools cannot bypass the host filesystem. Preserve failed native `fileChange` error detail rather than projecting only its proposed patch. The direct connection-cached WebSocket and stateless SSE transports are guarded fallbacks; never replay after app-server `turn/start` has been sent.
249
+
- Native Codex approval questions show the reason without appending the shell command; keep command details in tool events and preserve all provider approval decision values. See `docs/CODEX_CLI_PROVIDER.md`.
249
250
- Native Codex command failures must preserve error text and otherwise report declined status or exit code. Empty `aggregatedOutput` is not a useful failure result and must not become an unexplained blank tool row.
250
251
- Provider-native compaction is observable lifecycle, not merely a token-count change. Codex app-server `contextCompaction` item start/completion and legacy `thread/compacted` notifications must emit one deduplicated provider-compaction lifecycle; Claude `compact_boundary` must emit provider completion. ACP projects these through `_crewcoder/compaction_update` without claiming the CrewCoder durable transcript itself was rewritten.
251
252
- Nested Codex compaction must use CrewCoder's resolved policy instead of app-server's smaller model default. Pass the known `contextWindow`, computed model-relative `autoCompactTokenLimit`, and `total` scope as process-only Codex app-server configuration; never persist these overrides into the user's Codex config. Sol, Terra, and Luna GPT-5.6 variants are all 1,050,000-token models and therefore compact at 630,000 tokens when normal auto-compaction is enabled.
Copy file name to clipboardExpand all lines: crewcoder-agent/docs/CODEX_CLI_PROVIDER.md
+7Lines changed: 7 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -14,6 +14,13 @@ The binary is `codex` on `PATH`, or `CREWCODER_CODEX_PATH`. On Windows, npm inst
14
14
15
15
Over ACP, select it with a `codex-cli:<model>` model id.
16
16
17
+
## Approval questions
18
+
19
+
Native approval dialogs display the provider's reason as the wrapped question,
20
+
without appending the raw shell command. The command remains in its tool transcript
21
+
entry. Allow once, Allow session, and Decline keep their provider decision values;
22
+
cancellation or an unrecognized answer declines the request.
23
+
17
24
## No fallback
18
25
19
26
If the app-server cannot start, the turn fails with the cause. It never falls back to the direct Responses transport, because that would need CrewCoder-owned credentials.
Copy file name to clipboardExpand all lines: crewcoder-tui/AGENTS.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -268,6 +268,8 @@ While the backend bridge is running, ordinary non-command composer submissions m
268
268
269
269
Extension UI requests follow the same live control-channel pattern. `extension_ui_request` opens a focused popup (`ExtensionUiOverlay`) for `confirm`/`input`/`select`; the answer is written back over the `ui_response` control message via `CrewCoderProcessBridge.resolveUiRequest(requestId, value)`. The request renders as an `extension_ui` block that stays `pending` until `extension_ui_resolved`, then becomes `answered`/`cancelled`. `esc` cancels the request (sends `null`). `extension_ui_notify` renders inline (error/warning levels as error blocks, otherwise a system log). Do not collapse these into passive logs — they gate a live extension call.
270
270
271
+
Question dialogs show the question and reply controls without internal extension/request metadata. Keep reply controls visible even for long questions; PageUp/PageDown scrolls question text independently of selection. See `docs/QUESTIONS.md`. Transcript rows must normalize Windows line endings and contain terminal controls before painting; see `docs/TRANSCRIPT.md` and `src/tests/transcript-containment.test.ts`.
272
+
271
273
`ExtensionUiOverlay` must wrap, not truncate. The question title, the message, option labels, and option descriptions all wrap to the modal width; a description renders indented beneath its label rather than trailing it on the same row. Agent-authored questions are usually a full sentence and their options carry the rationale needed to choose, so a single truncated row hid the deciding text. `desiredHeight(width)` is measured from the wrapped content (App passes the modal `contentWidth`), and the option list scroll-windows to keep the whole selected option visible when the terminal is too short. Every rendered row of an option maps back to that option in `selectableRows`, so a click on a wrapped description row still selects it. Guarded by `src/tests/extension-ui-overlay.test.ts`.
0 commit comments