Skip to content

Fix workspace validation and request resource completeness - #21

Merged
LevinGuy merged 1 commit into
mainfrom
fix/asif-validation-consistency
Oct 9, 2026
Merged

LevinGuy merged 1 commit into
mainfrom
fix/asif-validation-consistency

Conversation

@LevinGuy

@LevinGuy LevinGuy commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Preflight could report a workspace ready even though restore rejected a normalized file/descendant collision. Workspace deltas could delete excluded descendants, and request projection omitted resources referenced only by selected tools. Fix all three behaviors in both Python and TypeScript.

  • Share destination path validation between preflight and restore, checking normalized duplicates and non-directory ancestors independently of entry order.
  • Validate every affected deletion target against exclusions before applying the operation.
  • Include selected tools’ explicit resource references in deterministic, deduplicated request resources, refusing unavailable bytes through the existing resolver.

Add shared positive and negative regression cases, update the continuation parity corpus, and exercise tool-resource projection through both CLIs. ASIF stays at 0.4, the package at 0.4.0, continuation/profile reports at 0.2, and request projection at 0.1.

Validation passed:

  • Python reference: 158 checks; continuation: 128 checks (also exported for TypeScript parity).
  • TypeScript: 269 tests and TypeScript type checking.
  • Python/TypeScript CLI exchange: 22 checks.
  • Schema: 30 checks; examples: 12 positive and 5 negative checks.
  • Documentation: 128 objects, 140 examples, generated-reference freshness, and strict MkDocs build.
  • git diff --check.

These remain locally authored reference implementations and synthetic checks; independent or live-runtime interoperability is not established by this PR.

Closes #12
Closes #13
Closes #14

The remaining backlog is tracked separately in #15–#20; #6 links its two deliverables (#16 and #17). Existing #5 and #7 remain open.

@LevinGuy LevinGuy added bug Something isn't working conformance Requirement coverage, validation, and interoperability evidence priority:P0 Must resolve before the capability or conformance claim stated in the issue labels Oct 9, 2026
@LevinGuy
LevinGuy merged commit 652d9e2 into main Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working conformance Requirement coverage, validation, and interoperability evidence priority:P0 Must resolve before the capability or conformance claim stated in the issue

Projects

None yet

1 participant