Repository navigation
chore: [SDK-5612] standardize push subscription UI in the demo app - #212
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abdulraqeeb33
approved these changes
Oct 27, 2026
abdulraqeeb33
left a comment
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Picker sync with the suppress flag looks right, and PushSubscriptionStatus updates from all three inputs.
…etLanguage Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaces the MAUI Picker (iOS wheel, Android dialog) with a page-level overlay menu anchored under the row, capped at 320, with language_option_<code> AutomationIds on each item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Standardize the demo push subscription UI and add a language selector.
Details
Motivation
Part of SDK-5300 (standardize push subscription UI across SDK demo apps). Matches the Android demo (OneSignal/OneSignal-Android-SDK#2760).
Scope
Demo app only (
examples/demo). SDK unchanged.push_subscription_status, same as Android.user_language_dropdown). It callssetLanguage(code), and Device Default sends'', which the native SDK resolves to the device language. The choice is saved only so the picker shows it after a restart; it is not re-sent at launch, since native keeps its own value. Login and logout reset the picker to Device Default locally, without callingsetLanguage.DropdownMenuoverlay instead of the MAUIPicker(iOS wheel, Android dialog): anchored under the row, right-aligned, capped at 320, opens upward near the bottom of the screen, and scrolls to the current choice. Items use aCollectionViewso a drag that ends on an item doesn't select it. Each item haslanguage_option_<code>as its AutomationId, matching RN, Expo and Unity.Testing
Unit testing
No unit tests; demo UI reading existing SDK state.
Manual testing
csharpier check .passes; the demo builds fornet10.0-androidandnet10.0-ioswith 0 warnings. Not yet run on a device or simulator.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code