Skip to content

Commit e37e2e9

Browse files
fix: require iOS 12 for OneSignal iOS 5.6.0 (#896)
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 2af00c3 commit e37e2e9

4 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎.github/workflows/codeql.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ concurrency:
77
on:
88
push:
99
branches: ["main"]
10-
pull_request:
11-
branches: ["main"]
1210
schedule:
1311
- cron: "32 13 * * 0"
1412

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ And via many additional platforms. [Check them all out](https://documentation.on
5252
- iOS Builds: CocoaPods 1.11.3 or newer
5353
- In order to test push notifications you will need
5454
- An Android 7 or newer device or emulator with "Google Play Store (Services)" installed
55-
- An iOS 11 or newer device (iPhone, iPad, or iPod Touch)
55+
- An iOS 12 or newer device (iPhone, iPad, or iPod Touch)
5656

5757
### Push Notification Credentials
5858
You must generate the appropriate credentials for the platform(s) you are releasing on:

‎com.onesignal.unity.ios/Editor/BuildPostProcessor.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ private void AddNotificationServiceExtension()
219219

220220
// Makes it so that the extension target is Universal (not just iPhone)
221221
_project.SetBuildProperty(extensionGuid, "TARGETED_DEVICE_FAMILY", "1,2");
222-
_project.SetBuildProperty(extensionGuid, "IPHONEOS_DEPLOYMENT_TARGET", "11.0");
222+
_project.SetBuildProperty(extensionGuid, "IPHONEOS_DEPLOYMENT_TARGET", "12.0");
223223
_project.SetBuildProperty(extensionGuid, "SWIFT_VERSION", "5.0");
224224
_project.SetBuildProperty(
225225
extensionGuid,

‎examples/demo/Assets/OneSignal/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ And via many additional platforms. [Check them all out](https://documentation.on
3737
- iOS Builds: CocoaPods 1.11.3 or newer
3838
- In order to test push notifications you will need
3939
- An Android 7 or newer device or emulator with "Google Play Store (Services)" installed
40-
- An iOS 11 or newer device (iPhone, iPad, or iPod Touch)
40+
- An iOS 12 or newer device (iPhone, iPad, or iPod Touch)
4141

4242
### Push Notification Credentials
4343
You must generate the appropriate credentials for the platform(s) you are releasing on:

0 commit comments

Comments
 (0)