Repository navigation
chore: run E2E on release PRs and build KMP in E2E - #1800
Closed
fadi-george wants to merge 2 commits into
Closed
fadi-george wants to merge 2 commits into
fadi-george wants to merge 2 commits into
Conversation
Pushes made with GITHUB_TOKEN don't start push-triggered workflows, so e2e.yml never ran for release branches built by this workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kflow Pass GH_PUSH_TOKEN to the shared prep and create-release workflows so the release PR is opened by a user token and pull_request workflows fire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/release-trigger-e2e
branch
from
November 10, 2026 01:13
ebd2a47 to
46c5a44
Compare
Contributor
Author
|
Changes already landed on main via #1799. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Run E2E on release PRs and build the OneSignalKMP XCFramework in E2E.
Details
Motivation
e2e.ymlruns on push torel/**, but the release workflow pushes and opens the PR withGITHUB_TOKEN, and GitHub doesn't start other workflows from those events. E2E never ran forrel/5.8.1(#1799); earlier release branches only ran it when someone pushed a manual fix.Scope
create-release-prs.yml: passGH_PUSH_TOKENto the sharedprepandcreate-ios-prworkflows, so the release PR is opened byonesignal-deployandpull_requestworkflows fire.e2e.yml: trigger onpull_request(jobs only run forrel/head branches) andworkflow_dispatch, instead ofpushtorel/**. Avoids a duplicate run per push alongside the PR'ssynchronize.e2e.yml: check out submodules and build the OneSignalKMP XCFramework (cached, same key asci.yml) before archiving the demo app. Without it the archive fails withunable to resolve module dependency: 'OneSignalKMP'.Testing
Manual testing
Workflow YAML validated locally. Full path will be exercised on the next release run.
Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code