Skip to content

chore: run E2E on release PRs and build KMP in E2E - #1800

Closed
fadi-george wants to merge 2 commits into
mainfrom
fadi/release-trigger-e2e
Closed

fadi-george wants to merge 2 commits into
mainfrom
fadi/release-trigger-e2e

Conversation

@fadi-george

@fadi-george fadi-george commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Run E2E on release PRs and build the OneSignalKMP XCFramework in E2E.

Details

Motivation

e2e.yml runs on push to rel/**, but the release workflow pushes and opens the PR with GITHUB_TOKEN, and GitHub doesn't start other workflows from those events. E2E never ran for rel/5.8.1 (#1799); earlier release branches only ran it when someone pushed a manual fix.

Scope

  • create-release-prs.yml: pass GH_PUSH_TOKEN to the shared prep and create-ios-pr workflows, so the release PR is opened by onesignal-deploy and pull_request workflows fire.
  • e2e.yml: trigger on pull_request (jobs only run for rel/ head branches) and workflow_dispatch, instead of push to rel/**. Avoids a duplicate run per push alongside the PR's synchronize.
  • e2e.yml: check out submodules and build the OneSignalKMP XCFramework (cached, same key as ci.yml) before archiving the demo app. Without it the archive fails with unable to resolve module dependency: 'OneSignalKMP'.

Testing

Manual testing

Workflow YAML validated locally. Full path will be exercised on the next release run.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

@fadi-george fadi-george changed the title chore: trigger E2E tests from create release PRs workflow chore: trigger E2E from release workflow and build KMP in E2E Nov 7, 2026
@fadi-george fadi-george changed the title chore: trigger E2E from release workflow and build KMP in E2E chore: run E2E on release PRs and build KMP in E2E Nov 7, 2026
fadi-george and others added 2 commits November 9, 2026 17:13
Pushes made with GITHUB_TOKEN don't start push-triggered workflows, so
e2e.yml never ran for release branches built by this workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kflow

Pass GH_PUSH_TOKEN to the shared prep and create-release workflows so the
release PR is opened by a user token and pull_request workflows fire.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george force-pushed the fadi/release-trigger-e2e branch from ebd2a47 to 46c5a44 Compare November 10, 2026 01:13
@fadi-george

Copy link
Copy Markdown
Contributor Author

Changes already landed on main via #1799.

@fadi-george
fadi-george deleted the fadi/release-trigger-e2e branch November 10, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant