Repository navigation
chore: [SDK-5587] sign iOS demo with enterprise team and sdkdemo IDs - #1810
Conversation
Move the demo to the OneSignal, Inc. Enterprise team (DL8TF3X4K3) so BrowserStack can run in-house builds, and rename identifiers from com.onesignal.example to com.onesignal.sdkdemo (main, NSE, LA, App Group). Release signs with the in-house distribution identity and exports with method enterprise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dialogs slid up when the keyboard appeared, but XCUITest kept reporting the old frames, so Appium taps on dialog buttons (e.g. "+ Add" in Add Multiple Tags) missed. Anchor dialogs near the top and ignore the keyboard safe area so they never move while open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With dialogs pinned and ignoring the keyboard, the Track Event JSON editor expanded to fill the screen and pushed the Track button under the keyboard on iOS 26. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Local sdk-shared Appium run ( |
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Reviewed with a three-model fan-out (Opus, Grok, GPT) plus a manual pass. The identifier sweep is complete and internally consistent: project.yml, both entitlements files, both Info.plists, ExportOptions.plist and the docs all agree on com.onesignal.sdkdemo and group.com.onesignal.sdkdemo.onesignal. The real-device BrowserStack run is good evidence this works today.
Two things I'd want resolved before merge, both inline: the aps-environment value under enterprise signing, and the dialog losing its height bound. Four findings aren't anchorable because .github/workflows/e2e.yml isn't in this diff:
-
e2e.yml:79-85callssetup-ios-demo-codesigning@mainwithoutprofile-type, so it defaults toIOS_APP_DEVELOPMENT. OneSignal/sdk-shared#63 updates the bundle ID defaults but doesn't add In House support, so even after both land the archive won't find the "Appium Demo - *" profiles. Looks likeprofile-type: IOS_APP_INHOUSEis needed on both sides. -
e2e.yml:114is the only guard between a signing mistake and a silently undeliverable run, andgrep -q 'aps-environment'passes ondevelopmentjust as happily asproduction. Asserting the value (and repeating it forPlugIns/*.appex) would make it catch the inline finding onApp.entitlements. -
e2e.yml:81still feedsAPPIUM_IOS_DEV_CERT_P12_BASE64into a job that now archives againstiPhone Distribution. Worth renaming so the next reader isn't misled about which certificate the job needs. -
examples/demo/OneSignalWidget/OneSignalWidgetLiveActivity.swift:59still registerskind: "com.onesignal.example.catalyst-placeholder". The kind is opaque so nothing breaks, but it's the lastcom.onesignal.examplereference left insideexamples/demo.
On testing: build-ios is gated on startsWith(github.head_ref, 'rel/'), so a PR whose whole purpose is a correctly signed IPA and a fixed Appium dialog interaction runs no CI that exercises either. Adding examples/demo/** as a trigger for build-ios would at least cover the archive, export and entitlement check on PRs like this one.
One thing I checked and am explicitly not flagging: the retry-test.sh:20 comment about other demos sharing the bundle ID is still accurate, since sdk-shared#63 moves every demo to com.onesignal.sdkdemo.
Set aps-environment from APS_ENVIRONMENT (development for Debug, production for Release) so it matches the In House profiles. Scope the App Release signing identity to iphoneos like the extensions. Move the Debug team default into Build.xcconfig so Local.xcconfig can override it. Document Release signing in build.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… in a grid Drop fixedSize from the dialog presenter and give OSTextEditor a fixed height instead, so dialogs stay within the screen in landscape and TooltipDialog's ScrollView fallback works again. Rename osCenteredDialog to osDialog now that dialogs are top-anchored. Add ButtonGrid (two columns, odd last button spans both) and use it for every section with two or more buttons, matching Send In-App Message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADD MULTIPLE {TAGS,ALIASES,TRIGGERS} -> ADD {TAGS,ALIASES,TRIGGERS} and
CLEAR ALL TRIGGERS -> CLEAR ALL so they fit the two-column grid without
scaling down.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
START/END LIVE ACTIVITY -> START/END ACTIVITY; the section title already names Live Activities and the shorter label fits a grid cell unscaled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Description
One Line Summary
Sign the iOS demo with the OneSignal, Inc. Enterprise team using
com.onesignal.sdkdemoIDs, and keep demo dialogs fixed while the keyboard is open.Details
Motivation
BrowserStack needs an in-house (Enterprise) signed build to run the iOS notification Appium tests that are currently skipped.
com.onesignal.exampleis owned by the Lilomi team, so the demo moves tocom.onesignal.sdkdemoon teamDL8TF3X4K3.While running the suite locally, the "add and remove multiple tags" test failed on iOS 26 and 27: demo dialogs slid up when the keyboard appeared, but XCUITest kept reporting the old frames, so Appium tapped empty space.
Scope
project.yml(and regeneratedApp.xcodeproj): team99SW8E36CT→DL8TF3X4K3, bundle IDscom.onesignal.example*→com.onesignal.sdkdemo*, Release signs with iPhone Distribution and the "Appium Demo - …" In House profiles.OneSignal_app_groups_key:group.com.onesignal.sdkdemo.onesignal.ExportOptions.plist:methodenterprise, new team and bundle IDs.OSDialog: dialogs are anchored near the top and ignore the keyboard safe area (visual change: no longer vertically centered).retry-test.shdefault bundle ID.Other
Part of SDK-5585. e2e will fail until the
APPIUM_*signing secrets and sdk-shared In House profile support land; merge together with those.Testing
Manual testing
iPhone Distribution: OneSignal, Inc.and the In House profiles.run-local.sh --sdk=ios), full suite 01-13: 36/36 passing on iOS 27.0 (iPhone 18 Pro) and iOS 26.5 (iPhone 17) simulators.itSkipBsIosskips removed locally andresignApp: false/video: falseinbstack:options: sdk-5587-enterprise-full-3 #1. Full suite 36/36 passing on a real iPhone 17 (iOS 26), including the tests CI currently skips on BrowserStack iOS: push ID/enabled and image notification (02), Live Activity start/update/end (12) and notification click (13). This shows the Enterprise-signed build can run push notification tests on a real iOS device.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code