Skip to content

chore: [SDK-5587] sign iOS demo with enterprise team and sdkdemo IDs - #1810

Merged
fadi-george merged 7 commits into
mainfrom
fadi/SDK-5587
Nov 17, 2026
Merged

fadi-george merged 7 commits into
mainfrom
fadi/SDK-5587

Conversation

@fadi-george

@fadi-george fadi-george commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Sign the iOS demo with the OneSignal, Inc. Enterprise team using com.onesignal.sdkdemo IDs, and keep demo dialogs fixed while the keyboard is open.

Details

Motivation

BrowserStack needs an in-house (Enterprise) signed build to run the iOS notification Appium tests that are currently skipped. com.onesignal.example is owned by the Lilomi team, so the demo moves to com.onesignal.sdkdemo on team DL8TF3X4K3.

While running the suite locally, the "add and remove multiple tags" test failed on iOS 26 and 27: demo dialogs slid up when the keyboard appeared, but XCUITest kept reporting the old frames, so Appium tapped empty space.

Scope

  • project.yml (and regenerated App.xcodeproj): team 99SW8E36CT → DL8TF3X4K3, bundle IDs com.onesignal.example* → com.onesignal.sdkdemo*, Release signs with iPhone Distribution and the "Appium Demo - …" In House profiles.
  • Entitlements + OneSignal_app_groups_key: group.com.onesignal.sdkdemo.onesignal.
  • ExportOptions.plist: method enterprise, new team and bundle IDs.
  • OSDialog: dialogs are anchored near the top and ignore the keyboard safe area (visual change: no longer vertically centered).
  • Docs and retry-test.sh default bundle ID.
  • No SDK source changes.

Other

Part of SDK-5585. e2e will fail until the APPIUM_* signing secrets and sdk-shared In House profile support land; merge together with those.

Testing

Manual testing

  • Release device build signs App, NSE and Widget with iPhone Distribution: OneSignal, Inc. and the In House profiles.
  • Local sdk-shared Appium run (run-local.sh --sdk=ios), full suite 01-13: 36/36 passing on iOS 27.0 (iPhone 18 Pro) and iOS 26.5 (iPhone 17) simulators.
  • Manual BrowserStack App Automate run of an Enterprise-signed IPA built from this branch, with the itSkipBsIos skips removed locally and resignApp: false / video: false in bstack:options: sdk-5587-enterprise-full-3 #1. Full suite 36/36 passing on a real iPhone 17 (iOS 26), including the tests CI currently skips on BrowserStack iOS: push ID/enabled and image notification (02), Live Activity start/update/end (12) and notification click (13). This shows the Enterprise-signed build can run push notification tests on a real iOS device.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

fadi-george and others added 2 commits November 16, 2026 14:46
Move the demo to the OneSignal, Inc. Enterprise team (DL8TF3X4K3) so
BrowserStack can run in-house builds, and rename identifiers from
com.onesignal.example to com.onesignal.sdkdemo (main, NSE, LA, App Group).
Release signs with the in-house distribution identity and exports with
method enterprise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dialogs slid up when the keyboard appeared, but XCUITest kept reporting
the old frames, so Appium taps on dialog buttons (e.g. "+ Add" in Add
Multiple Tags) missed. Anchor dialogs near the top and ignore the keyboard
safe area so they never move while open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from nan-li November 17, 2026 00:34
With dialogs pinned and ignoring the keyboard, the Track Event JSON editor
expanded to fill the screen and pushed the Track button under the keyboard
on iOS 26.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george

Copy link
Copy Markdown
Contributor Author

Local sdk-shared Appium run (run-local.sh --sdk=ios, full suite 01-13) on this branch: 36/36 passing on iOS 26.5 (iPhone 17) and iOS 27.0 (iPhone 18 Pro) simulators, including multiple tags (07), custom events (10) and Live Activity start/update/end (12).

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with a three-model fan-out (Opus, Grok, GPT) plus a manual pass. The identifier sweep is complete and internally consistent: project.yml, both entitlements files, both Info.plists, ExportOptions.plist and the docs all agree on com.onesignal.sdkdemo and group.com.onesignal.sdkdemo.onesignal. The real-device BrowserStack run is good evidence this works today.

Two things I'd want resolved before merge, both inline: the aps-environment value under enterprise signing, and the dialog losing its height bound. Four findings aren't anchorable because .github/workflows/e2e.yml isn't in this diff:

  1. e2e.yml:79-85 calls setup-ios-demo-codesigning@main without profile-type, so it defaults to IOS_APP_DEVELOPMENT. OneSignal/sdk-shared#63 updates the bundle ID defaults but doesn't add In House support, so even after both land the archive won't find the "Appium Demo - *" profiles. Looks like profile-type: IOS_APP_INHOUSE is needed on both sides.

  2. e2e.yml:114 is the only guard between a signing mistake and a silently undeliverable run, and grep -q 'aps-environment' passes on development just as happily as production. Asserting the value (and repeating it for PlugIns/*.appex) would make it catch the inline finding on App.entitlements.

  3. e2e.yml:81 still feeds APPIUM_IOS_DEV_CERT_P12_BASE64 into a job that now archives against iPhone Distribution. Worth renaming so the next reader isn't misled about which certificate the job needs.

  4. examples/demo/OneSignalWidget/OneSignalWidgetLiveActivity.swift:59 still registers kind: "com.onesignal.example.catalyst-placeholder". The kind is opaque so nothing breaks, but it's the last com.onesignal.example reference left inside examples/demo.

On testing: build-ios is gated on startsWith(github.head_ref, 'rel/'), so a PR whose whole purpose is a correctly signed IPA and a fixed Appium dialog interaction runs no CI that exercises either. Adding examples/demo/** as a trigger for build-ios would at least cover the archive, export and entitlement check on PRs like this one.

One thing I checked and am explicitly not flagging: the retry-test.sh:20 comment about other demos sharing the bundle ID is still accurate, since sdk-shared#63 moves every demo to com.onesignal.sdkdemo.

Comment thread examples/demo/App.entitlements Resolved
Comment thread examples/demo/project.yml Resolved
Comment thread examples/demo/project.yml Resolved
Comment thread examples/demo/build.md Resolved
fadi-george and others added 4 commits November 17, 2026 10:23
Set aps-environment from APS_ENVIRONMENT (development for Debug,
production for Release) so it matches the In House profiles. Scope the
App Release signing identity to iphoneos like the extensions. Move the
Debug team default into Build.xcconfig so Local.xcconfig can override
it. Document Release signing in build.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… in a grid

Drop fixedSize from the dialog presenter and give OSTextEditor a fixed
height instead, so dialogs stay within the screen in landscape and
TooltipDialog's ScrollView fallback works again. Rename
osCenteredDialog to osDialog now that dialogs are top-anchored.

Add ButtonGrid (two columns, odd last button spans both) and use it for
every section with two or more buttons, matching Send In-App Message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADD MULTIPLE {TAGS,ALIASES,TRIGGERS} -> ADD {TAGS,ALIASES,TRIGGERS} and
CLEAR ALL TRIGGERS -> CLEAR ALL so they fit the two-column grid without
scaling down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
START/END LIVE ACTIVITY -> START/END ACTIVITY; the section title already
names Live Activities and the shorter label fits a grid cell unscaled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george merged commit a196bd1 into main Nov 17, 2026
12 of 14 checks passed
@fadi-george
fadi-george deleted the fadi/SDK-5587 branch November 17, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants