Repository navigation
ci: [SDK-5587] pin enterprise signing for every e2e archive target - #1812
Merged
Merged
Conversation
The Enterprise team has no App Store Connect API, so the codesigning action now takes the In House profiles directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sherwinski
approved these changes
Nov 18, 2026
abdulraqeeb33
approved these changes
Nov 18, 2026
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
Approve.
The archive step now passes CODE_SIGN_IDENTITY="iPhone Distribution" and DEVELOPMENT_TEAM=DL8TF3X4K3 for every target in the App scheme. That matches the demo Release settings and ExportOptions.plist (enterprise, same team, manual). OneSignal.xcodeproj still has team 99SW8E36CT, and this override is only on the e2e archive.
Dispatch on 76da014 is green: archive, export, aps-environment, 36/36 on device.
https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/44207863039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Pin the in-house distribution identity and Enterprise team for every target in the e2e archive so the IPA builds with the only cert CI has.
Details
Motivation
After moving e2e signing to the Enterprise team (#1810), the archive failed:
CODE_SIGN_STYLE=Manualon the command line also applies to the SDK framework targets built fromOneSignal.xcodeproj, which default to a development identity and the SDK release team (99SW8E36CT). CI only has the in-house "iPhone Distribution" cert, so signing failed with "No 'iOS Development' / 'iOS Distribution' certificate … 99SW8E36CT".Scope
e2e.ymlarchive step: addCODE_SIGN_IDENTITY="iPhone Distribution"andDEVELOPMENT_TEAM=DL8TF3X4K3. The demo targets already use these values.OneSignal.xcodeprojis unchanged, so release builds and XCFramework signing are unaffected.main:setup-ios-demo-codesigningnow downloads the In House profiles through the Enterprise Program API (api.enterprise.developer.apple.com,aud: apple-developer-enterprise-v1). That was the cause of the earlier App Store Connect 401s. No secret changes needed.Testing
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code