Skip to content

ci: [SDK-5587] pin enterprise signing for every e2e archive target - #1812

Merged
fadi-george merged 4 commits into
mainfrom
fadi/sdk-5587-e2e-profiles
Nov 18, 2026
Merged

fadi-george merged 4 commits into
mainfrom
fadi/sdk-5587-e2e-profiles

Conversation

@fadi-george

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Pin the in-house distribution identity and Enterprise team for every target in the e2e archive so the IPA builds with the only cert CI has.

Details

Motivation

After moving e2e signing to the Enterprise team (#1810), the archive failed: CODE_SIGN_STYLE=Manual on the command line also applies to the SDK framework targets built from OneSignal.xcodeproj, which default to a development identity and the SDK release team (99SW8E36CT). CI only has the in-house "iPhone Distribution" cert, so signing failed with "No 'iOS Development' / 'iOS Distribution' certificate … 99SW8E36CT".

Scope

  • e2e.yml archive step: add CODE_SIGN_IDENTITY="iPhone Distribution" and DEVELOPMENT_TEAM=DL8TF3X4K3. The demo targets already use these values.
  • OneSignal.xcodeproj is unchanged, so release builds and XCFramework signing are unaffected.
  • Related, already on sdk-shared main: setup-ios-demo-codesigning now downloads the In House profiles through the Enterprise Program API (api.enterprise.developer.apple.com, aud: apple-developer-enterprise-v1). That was the cause of the earlier App Store Connect 401s. No secret changes needed.

Testing

Manual testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
    • CI-only change; verified by the E2E run above.
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

fadi-george and others added 4 commits November 17, 2026 16:15
The Enterprise team has no App Store Connect API, so the codesigning
action now takes the In House profiles directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

The archive step now passes CODE_SIGN_IDENTITY="iPhone Distribution" and DEVELOPMENT_TEAM=DL8TF3X4K3 for every target in the App scheme. That matches the demo Release settings and ExportOptions.plist (enterprise, same team, manual). OneSignal.xcodeproj still has team 99SW8E36CT, and this override is only on the e2e archive.

Dispatch on 76da014 is green: archive, export, aps-environment, 36/36 on device.
https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/44207863039

@fadi-george
fadi-george merged commit de073c0 into main Nov 18, 2026
4 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5587-e2e-profiles branch November 18, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants