Skip to content

chore: pin demo extension pods in release PRs and fix Xcode 27 pod targets - #2010

Closed
fadi-george wants to merge 1 commit into
mainfrom
fadi/release-pr-podfile
Closed

fadi-george wants to merge 1 commit into
mainfrom
fadi/release-pr-podfile

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Pin the demo's extension OneSignalXCFramework pods to the iOS SDK version on each release, and raise pod deployment targets so the demo builds with Xcode 27.

Details

Motivation

  • The demo's NSE and widget extension targets used '>= 5.0.0', '< 6.0', so they weren't pinned to the iOS SDK version the release ships with. The release workflow now pins them alongside react-native-onesignal.podspec.
  • Xcode 27 rejects pod deployment targets below iOS 15. RNSVG (12.4) and RNCAsyncStorage (13.4) still declare older minimums, so the demo fails to build locally with Xcode 27 (hit while running iOS E2E for 5.5.17).

Scope

  • create-release-pr.yml: the "Update iOS SDK version" step also sets both pod 'OneSignalXCFramework', '<version>' lines in examples/demo/ios/Podfile, and fails if it can't update both. The existing Podfile.lock refresh step picks up the change.
  • examples/demo/ios/Podfile: extension pods pinned to 5.8.0 (current podspec version on main); post_install raises any pod target below min_ios_version_supported (15.1).
  • examples/demo-no-location/ios/Podfile: same post_install fix.
  • Podfile.lock: only the OneSignalXCFramework dependency line and PODFILE CHECKSUM changed.

Merge order: release PR #2009 bumps the podspec to 5.8.1. If it merges first, this PR's pins need to move to 5.8.1 before merging.

Testing

Manual testing

  • pod install in examples/demo/ios with Xcode 27.1: all 176 Pods build configurations at IPHONEOS_DEPLOYMENT_TARGET = 15.1.
  • Ran the workflow's sed with BSD sed against the Podfile: both pins updated, guard count = 2.
  • Same deployment target fix let the 5.5.17 iOS E2E (run-local.sh --sdk=react-native --platform=ios) build and pass on Xcode 27.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

🤖 Generated with Claude Code

…rgets

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from a team as a code owner November 7, 2026 04:18
@fadi-george

Copy link
Copy Markdown
Collaborator Author

Committed directly to main (f9eba36, 34c6d58).

@fadi-george fadi-george closed this Nov 7, 2026
@fadi-george
fadi-george deleted the fadi/release-pr-podfile branch November 7, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant