Repository navigation
chore: pin demo extension pods in release PRs and fix Xcode 27 pod targets - #2010
Closed
fadi-george wants to merge 1 commit into
Closed
fadi-george wants to merge 1 commit into
fadi-george wants to merge 1 commit into
Conversation
…rgets Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Pin the demo's extension
OneSignalXCFrameworkpods to the iOS SDK version on each release, and raise pod deployment targets so the demo builds with Xcode 27.Details
Motivation
'>= 5.0.0', '< 6.0', so they weren't pinned to the iOS SDK version the release ships with. The release workflow now pins them alongsidereact-native-onesignal.podspec.RNSVG(12.4) andRNCAsyncStorage(13.4) still declare older minimums, so the demo fails to build locally with Xcode 27 (hit while running iOS E2E for 5.5.17).Scope
create-release-pr.yml: the "Update iOS SDK version" step also sets bothpod 'OneSignalXCFramework', '<version>'lines inexamples/demo/ios/Podfile, and fails if it can't update both. The existing Podfile.lock refresh step picks up the change.examples/demo/ios/Podfile: extension pods pinned to5.8.0(current podspec version on main);post_installraises any pod target belowmin_ios_version_supported(15.1).examples/demo-no-location/ios/Podfile: samepost_installfix.Podfile.lock: only theOneSignalXCFrameworkdependency line andPODFILE CHECKSUMchanged.Merge order: release PR #2009 bumps the podspec to
5.8.1. If it merges first, this PR's pins need to move to5.8.1before merging.Testing
Manual testing
pod installinexamples/demo/ioswith Xcode 27.1: all 176 Pods build configurations atIPHONEOS_DEPLOYMENT_TARGET = 15.1.sedwith BSD sed against the Podfile: both pins updated, guard count = 2.run-local.sh --sdk=react-native --platform=ios) build and pass on Xcode 27.1.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code