Skip to content

chore: [SDK-5759] move React Native demos to the UIScene lifecycle for iOS 27 - #2014

Merged
fadi-george merged 2 commits into
mainfrom
fadi/sdk-5759
Nov 17, 2026
Merged

fadi-george merged 2 commits into
mainfrom
fadi/sdk-5759

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Move the React Native iOS demos (demo and demo-no-location) to the UIScene lifecycle so they launch when built with the iOS 27 SDK.

Details

Motivation

Apps built with the iOS 27 SDK must adopt the UIScene lifecycle. Without it, both demos crash at launch with SIGTRAP in _UIApplicationEvaluateRuntimeIssueForNoSceneLifecycleAdoption. This blocks the Appium suite on iOS 27.

Scope

Examples only, no SDK code changes.

  • AppDelegate.swift creates the RCTReactNativeFactory but no longer creates the window.
  • New SceneDelegate.swift creates a UIWindow for the connected scene and starts React Native in it.
  • Info.plist declares a single-scene UIApplicationSceneManifest pointing at the scene delegate.
  • project.pbxproj adds SceneDelegate.swift to the demo target.

React Native is now started with launchOptions: nil, since scene-based apps don't receive launch options in the app delegate. The demos don't rely on them, and OneSignal handles cold-start notification taps itself.

Testing

Manual testing

Xcode 27.1, temporary simulators.

  • iPhone 18 Pro, iOS 27.0: full Appium suite passes (36/36), including cold-start and background notification tap tests.
  • iOS 26.5: user, push, and notification click specs pass.
  • demo-no-location: Debug and Release builds succeed; Release launches on iOS 27.0.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

iOS 27 SDK builds crash at launch without a scene delegate. Start
React Native from a SceneDelegate and declare a single-scene manifest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from a team as a code owner November 16, 2026 23:03

@nan-li nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo app only changes, lgtm

  1. it would be more appropriate to rename PR to "chore"?
  2. update build-ios.md to note scene setup

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george fadi-george changed the title fix: [SDK-5759] move React Native demos to the UIScene lifecycle for iOS 27 chore: [SDK-5759] move React Native demos to the UIScene lifecycle for iOS 27 Nov 17, 2026
@fadi-george

Copy link
Copy Markdown
Collaborator Author

Thanks! Renamed to chore and added a scene lifecycle section to build-ios.md in 5933dab.

@fadi-george
fadi-george merged commit 72874b3 into main Nov 17, 2026
3 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5759 branch November 17, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants