Skip to content

chore: [SDK-5590] sign demos with enterprise team and sdkdemo IDs - #2015

Merged
fadi-george merged 4 commits into
mainfrom
fadi/sdk-5590
Nov 18, 2026
Merged

fadi-george merged 4 commits into
mainfrom
fadi/sdk-5590

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Sign the iOS demos with the OneSignal Enterprise team and com.onesignal.sdkdemo IDs, and align the demo UI with the shared build.md (button grid, top-anchored dialogs, shorter labels).

Details

Motivation

BrowserStack needs an In House signed IPA it can install without re-signing (resignApp: false) so push entitlements survive and the iOS push E2E tests run on real devices. The UI changes match the shared demo spec and the Capacitor/Cordova demos; dialogs that stay put keep Appium element frames accurate.

Scope

  • demo, demo-no-location: iOS IDs com.onesignal.sdkdemo (.NSE, .LA), app group group.com.onesignal.sdkdemo.onesignal, team DL8TF3X4K3. Release signs with iPhone Distribution and the Appium Demo - Main / NSE / Live Activity In House profiles; ExportOptions.plist method enterprise. Android was already com.onesignal.sdkdemo.
  • ButtonGrid: a flex-wrap row; grid buttons grow from a 40% basis (via context in ActionButton), so an odd last button spans and conditionally rendered buttons reflow, matching the web demos' CSS grid.
  • DialogBackdrop: dialogs anchor at the top (24pt + safe area) and cap at 640 wide; KeyboardAvoidingView padding only shrinks the space below, so the card doesn't move. Tooltip uses the same insets.
  • Labels: ADD TAGS / ALIASES / TRIGGERS, CLEAR ALL, START / END ACTIVITY, CHECK LOCATION (now primary, like the web demos); Live Activity status label replaces every underscore; event properties input bounded to 90-200.
  • build-ios.md signing section and README updated. No SDK code changes.

Testing

Manual testing

  • Full sdk-shared Appium suite on an iOS 26.5 simulator: 36/36 passing.
  • Checked the grid in every section, tag/trigger reflow, and dialog position with the keyboard open.
  • xcodebuild -showBuildSettings confirms Release signing for all three targets.
  • vp check and tsc --noEmit pass.
  • Not yet verified: the enterprise-signed IPA in CI. iOS E2E is blocked at profile download by an App Store Connect API 401 (same on every SDK repo).

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
    • Demo/CI only; covered by the sdk-shared Appium suite.
  • All automated tests pass, or I explained why that is not possible
    • iOS E2E blocked by the App Store Connect 401 (see Testing).
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

fadi-george and others added 3 commits November 17, 2026 14:14
- iOS bundle IDs move to com.onesignal.sdkdemo (.NSE, .LA) and the
  group.com.onesignal.sdkdemo.onesignal app group.
- Team DL8TF3X4K3; Release signs with the in-house iPhone Distribution
  cert and ExportOptions uses enterprise, so BrowserStack can install the
  IPA without re-signing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ButtonGrid lays out section buttons two per row; an odd last button
  spans, conditionally rendered buttons reflow.
- DialogBackdrop anchors dialogs at the top below the safe area; keyboard
  padding only shrinks the space below, so dialogs stay put.
- Shorter labels (ADD TAGS/ALIASES/TRIGGERS, CLEAR ALL, START/END
  ACTIVITY, CHECK LOCATION) and every underscore in the Live Activity
  status label is replaced.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ButtonGrid is a flex-wrap row; grid buttons grow from a 40% basis so an
  odd last button spans, matching the web demos' CSS grid.
- CHECK LOCATION uses the primary style, the event properties input is
  bounded (90-200), and dialogs cap at 640 wide with a 24pt + safe area
  bottom inset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment. Not blocking.

examples/demo matches the Cordova signing setup: team DL8TF3X4K3, Release iPhone Distribution for device, enterprise export, com.onesignal.sdkdemo / .NSE / .LA, and the shared app group. Grid and top-anchored dialogs match the shared demo spec. testIDs are unchanged.

  1. demo-no-location does not get .NSE / .LA. That pbxproj has one native target and an empty Embed Foundation Extensions phase. ExportOptions and the NSE entitlements now name bundles that target never builds. e2e.yml archives examples/demo only. Drop .NSE / .LA from the no-location scope, or add those targets the way examples/demo has them.

Nit: on iOS, DialogBackdrop's KeyboardAvoidingView writes paddingBottom: 0 while the keyboard is closed, so insets.bottom + 24 never shows. Top inset is kept. Put the safe-area padding on an inner view.

…oidingView

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george merged commit 6da6054 into main Nov 18, 2026
2 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5590 branch November 18, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants