Repository navigation
chore: [SDK-5590] sign demos with enterprise team and sdkdemo IDs - #2015
Merged
Merged
Conversation
- iOS bundle IDs move to com.onesignal.sdkdemo (.NSE, .LA) and the group.com.onesignal.sdkdemo.onesignal app group. - Team DL8TF3X4K3; Release signs with the in-house iPhone Distribution cert and ExportOptions uses enterprise, so BrowserStack can install the IPA without re-signing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ButtonGrid lays out section buttons two per row; an odd last button spans, conditionally rendered buttons reflow. - DialogBackdrop anchors dialogs at the top below the safe area; keyboard padding only shrinks the space below, so dialogs stay put. - Shorter labels (ADD TAGS/ALIASES/TRIGGERS, CLEAR ALL, START/END ACTIVITY, CHECK LOCATION) and every underscore in the Live Activity status label is replaced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ButtonGrid is a flex-wrap row; grid buttons grow from a 40% basis so an odd last button spans, matching the web demos' CSS grid. - CHECK LOCATION uses the primary style, the event properties input is bounded (90-200), and dialogs cap at 640 wide with a 24pt + safe area bottom inset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7 of 8 tasks
sherwinski
approved these changes
Nov 18, 2026
abdulraqeeb33
approved these changes
Nov 18, 2026
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
Comment. Not blocking.
examples/demo matches the Cordova signing setup: team DL8TF3X4K3, Release iPhone Distribution for device, enterprise export, com.onesignal.sdkdemo / .NSE / .LA, and the shared app group. Grid and top-anchored dialogs match the shared demo spec. testIDs are unchanged.
- demo-no-location does not get .NSE / .LA. That pbxproj has one native target and an empty Embed Foundation Extensions phase. ExportOptions and the NSE entitlements now name bundles that target never builds. e2e.yml archives examples/demo only. Drop .NSE / .LA from the no-location scope, or add those targets the way examples/demo has them.
Nit: on iOS, DialogBackdrop's KeyboardAvoidingView writes paddingBottom: 0 while the keyboard is closed, so insets.bottom + 24 never shows. Top inset is kept. Put the safe-area padding on an inner view.
…oidingView Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Sign the iOS demos with the OneSignal Enterprise team and
com.onesignal.sdkdemoIDs, and align the demo UI with the shared build.md (button grid, top-anchored dialogs, shorter labels).Details
Motivation
BrowserStack needs an In House signed IPA it can install without re-signing (
resignApp: false) so push entitlements survive and the iOS push E2E tests run on real devices. The UI changes match the shared demo spec and the Capacitor/Cordova demos; dialogs that stay put keep Appium element frames accurate.Scope
demo,demo-no-location: iOS IDscom.onesignal.sdkdemo(.NSE,.LA), app groupgroup.com.onesignal.sdkdemo.onesignal, teamDL8TF3X4K3. Release signs withiPhone Distributionand theAppium Demo - Main / NSE / Live ActivityIn House profiles;ExportOptions.plistmethodenterprise. Android was alreadycom.onesignal.sdkdemo.ButtonGrid: a flex-wrap row; grid buttons grow from a 40% basis (via context inActionButton), so an odd last button spans and conditionally rendered buttons reflow, matching the web demos' CSS grid.DialogBackdrop: dialogs anchor at the top (24pt + safe area) and cap at 640 wide;KeyboardAvoidingViewpadding only shrinks the space below, so the card doesn't move. Tooltip uses the same insets.build-ios.mdsigning section and README updated. No SDK code changes.Testing
Manual testing
xcodebuild -showBuildSettingsconfirms Release signing for all three targets.vp checkandtsc --noEmitpass.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code