Repository navigation
chore: [SDK-5818] upgrade demos to React Native 0.88.1 (2/4) - #2019
Merged
Merged
Conversation
This was referenced Nov 20, 2026
sherwinski
approved these changes
Nov 20, 2026
Prerequisite for building the demo with React Native's Swift Package Manager mode, which needs 0.87 or later. Applies the upgrade-helper changes, bumps native dependencies that no longer compile against 0.88, and fixes the TypeScript errors from 0.88's function-component types and the removed StatusBar backgroundColor prop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi-sdk-5818-demo-rn-088
branch
from
November 21, 2026 02:07
fd65783 to
7d9ceb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Upgrade
examples/demoandexamples/demo-no-locationfrom React Native 0.84.0 to 0.88.1.Details
Motivation
React Native's Swift Package Manager mode needs 0.87 or later. PR 4 moves the demo to it.
Scope
nkfgem. The demos were already on the UIScene lifecycle.edgeToEdgeEnabledand status bar appearance are left as they were.react-native-screens,safe-area-context,svg, and@react-navigation/*within their ranges; screens 4.24 doesn't compile against 0.88 (RCTCxxBridge).View/ScrollViewrefs typed withReact.ComponentRef<typeof X>, and the removedStatusBar.backgroundColorprop dropped (it was already a no-op on Android 15+ edge-to-edge).demo-no-location'sPodfile.lockwas still on XCFramework 5.5.2; refreshed to 5.8.1.Stack
demo-podsappTesting
Manual testing
demoinstalled and run on an iOS 27 simulator: init, user + push subscription, permission prompt, language dropdown (exercises the retyped ref).assembleDebugfor both demos;demorelease APK built with the E2E command (assembleRelease -PciSingleAbi) and launched on a new Android 16 emulator, where it registered a push subscription.tsc --noEmitclean for both demos.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code