Repository navigation
chore: [SDK-5818] add CocoaPods demo-pods app (3/4) - #2020
Merged
Merged
Conversation
This was referenced Nov 20, 2026
fadi-george
force-pushed
the
fadi-sdk-5818-demo-pods
branch
from
November 20, 2026 21:53
60e93f7 to
c8d56e5
Compare
sherwinski
approved these changes
Nov 20, 2026
Copy the demo's iOS app into examples/demo-pods so the CocoaPods integration keeps a reference app and E2E coverage once demo moves to Swift Package Manager. Its JavaScript is shared with demo by copy, and a test fails when the two drift. iOS E2E and the release workflow's Podfile pin and lockfile refresh now cover demo-pods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi-sdk-5818-demo-pods
branch
from
November 21, 2026 02:07
c8d56e5 to
ed9059b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add
examples/demo-pods, the demo's iOS app on CocoaPods, and point the release workflow's Podfile steps at it.Details
Motivation
PR 4 moves
examples/demoto Swift Package Manager. Most apps are still on CocoaPods, so the CocoaPods integration keeps a reference app, following the Flutter SDK'sdemo/demo-podssplit. E2E stays ondemoand moves to SPM with it in PR 4.Scope
examples/demo-pods: a copy ofdemo's tracked files withoutandroid/(Android has no CocoaPods/SPM split). Onlypackage.jsonname/scripts, the Metro error message, and the README differ.__tests__/demoSync.test.ts: fails whenApp.tsx,src/,assets/,types/, the entry/config files, or dependencies drift fromdemo. Make JS changes indemoand copy them.demo's).Most of the diff is the copied app and its
bun.lock/Podfile.lock/pbxproj.Stack
demo-podsapp (this PR)Testing
Unit testing
The drift test; verified it fails on a one-line change to a copied file.
Manual testing
demo-pods:pod install, Release build, and run on an iOS 27 simulator; SDK initialized and showed the push subscription.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code