Skip to content

chore: [SDK-5818] add CocoaPods demo-pods app (3/4) - #2020

Merged
fadi-george merged 1 commit into
fadi-sdk-5818-demo-rn-088from
fadi-sdk-5818-demo-pods
Nov 21, 2026
Merged

fadi-george merged 1 commit into
fadi-sdk-5818-demo-rn-088from
fadi-sdk-5818-demo-pods

Conversation

@fadi-george

@fadi-george fadi-george commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Add examples/demo-pods, the demo's iOS app on CocoaPods, and point the release workflow's Podfile steps at it.

Details

Motivation

PR 4 moves examples/demo to Swift Package Manager. Most apps are still on CocoaPods, so the CocoaPods integration keeps a reference app, following the Flutter SDK's demo / demo-pods split. E2E stays on demo and moves to SPM with it in PR 4.

Scope

  • examples/demo-pods: a copy of demo's tracked files without android/ (Android has no CocoaPods/SPM split). Only package.json name/scripts, the Metro error message, and the README differ.
  • __tests__/demoSync.test.ts: fails when App.tsx, src/, assets/, types/, the entry/config files, or dependencies drift from demo. Make JS changes in demo and copy them.
  • Release workflow bumps the extension pod pins and refreshes lockfiles in both demos (PR 4 drops demo's).

Most of the diff is the copied app and its bun.lock/Podfile.lock/pbxproj.

Stack

  1. feat: [SDK-5818] add Package.swift for React Native SPM mode (1/4) #2018 Package.swift
  2. chore: [SDK-5818] upgrade demos to React Native 0.88.1 (2/4) #2019 Upgrade demos to RN 0.88.1
  3. chore: [SDK-5818] add CocoaPods demo-pods app (3/4) #2020 Add CocoaPods demo-pods app (this PR)
  4. chore: [SDK-5818] build the demo with Swift Package Manager (4/4) #2021 Build the demo with Swift Package Manager

Testing

Unit testing

The drift test; verified it fails on a one-line change to a copied file.

Manual testing

demo-pods: pod install, Release build, and run on an iOS 27 simulator; SDK initialized and showed the push subscription.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

Copy the demo's iOS app into examples/demo-pods so the CocoaPods
integration keeps a reference app and E2E coverage once demo moves to
Swift Package Manager. Its JavaScript is shared with demo by copy, and a
test fails when the two drift. iOS E2E and the release workflow's
Podfile pin and lockfile refresh now cover demo-pods.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george force-pushed the fadi-sdk-5818-demo-pods branch from c8d56e5 to ed9059b Compare November 21, 2026 02:07
@fadi-george
fadi-george merged commit 3541b5d into main Nov 21, 2026
3 of 4 checks passed
@fadi-george
fadi-george deleted the fadi-sdk-5818-demo-pods branch November 21, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants