Repository navigation
chore: [SDK-5818] build the React Native demo with SPM and support --pods - #75
Merged
Merged
Conversation
…pods React Native's examples/demo now builds with Swift Package Manager and examples/demo-pods keeps CocoaPods. build_rn_ios picks the build from whether the demo has a Podfile.lock, and --pods selects demo-pods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
React Native's
examples/demonow builds with Swift Package Manager (OneSignal/react-native-onesignal#2021) andexamples/demo-podskeeps CocoaPods.run-local.sh --sdk=react-nativestill builtdemo.xcworkspace, which no longer exists, so local RN iOS runs fail on RNmain.Details
build_rn_ios: a demo withios/Podfile.lockkeeps the CocoaPods path (update:pods,demo.xcworkspace). Without one it runsvp run update:spmand buildsdemo.xcodeproj. Older RN checkouts with a CocoaPodsdemokeep working.--podsnow supportsreact-nativeand selectsexamples/demo-pods.setup_rn_sdk:Package.swiftis part of the SDK source hash, and the stamp moves into the demo folder sincedemoanddemo-podseach install their own SDK copy.--podsrow updated.Testing
Against the RN stack (OneSignal/react-native-onesignal#2018 to #2021), temporary iPhone 17 / iOS 26.5 simulator and Android 17 emulator:
--platform=ios --sdk=react-native: 36 passing--platform=ios --sdk=react-native --pods: 36 passing--platform=android --sdk=react-native: 34 passing (first run hit agetElementRectflake in07_tag, rerun clean)The per-demo stamp change came after those runs.
🤖 Generated with Claude Code