Skip to content

chore: [SDK-5818] build the React Native demo with SPM and support --pods - #75

Merged
fadi-george merged 1 commit into
mainfrom
fadi/sdk-5818-rn-spm
Nov 21, 2026
Merged

fadi-george merged 1 commit into
mainfrom
fadi/sdk-5818-rn-spm

Conversation

@fadi-george

Copy link
Copy Markdown
Contributor

Description

React Native's examples/demo now builds with Swift Package Manager (OneSignal/react-native-onesignal#2021) and examples/demo-pods keeps CocoaPods. run-local.sh --sdk=react-native still built demo.xcworkspace, which no longer exists, so local RN iOS runs fail on RN main.

Details

  • build_rn_ios: a demo with ios/Podfile.lock keeps the CocoaPods path (update:pods, demo.xcworkspace). Without one it runs vp run update:spm and builds demo.xcodeproj. Older RN checkouts with a CocoaPods demo keep working.
  • --pods now supports react-native and selects examples/demo-pods.
  • setup_rn_sdk: Package.swift is part of the SDK source hash, and the stamp moves into the demo folder since demo and demo-pods each install their own SDK copy.
  • README --pods row updated.

Testing

Against the RN stack (OneSignal/react-native-onesignal#2018 to #2021), temporary iPhone 17 / iOS 26.5 simulator and Android 17 emulator:

  • --platform=ios --sdk=react-native: 36 passing
  • --platform=ios --sdk=react-native --pods: 36 passing
  • --platform=android --sdk=react-native: 34 passing (first run hit a getElementRect flake in 07_tag, rerun clean)

The per-demo stamp change came after those runs.

🤖 Generated with Claude Code

…pods

React Native's examples/demo now builds with Swift Package Manager and
examples/demo-pods keeps CocoaPods. build_rn_ios picks the build from whether
the demo has a Podfile.lock, and --pods selects demo-pods.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from a team as a code owner November 21, 2026 04:35
@fadi-george
fadi-george merged commit fcbfdac into main Nov 21, 2026
@fadi-george
fadi-george deleted the fadi/sdk-5818-rn-spm branch November 21, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant