Repository navigation
chore(wms): freeze WmsConnector boundary + CI lint guard (h02x.10.6) - #413
Merged
Merged
Conversation
…soft leaks (h02x.10.6) Lock in the connector-agnostic WMS boundary built across h02x.10.1–.5 so a regression can't silently re-introduce a 'mintsoft' branch into a core flow. - scripts/check-wms-connector-boundary.mjs: static guard — fails if the `mintsoft` literal appears in any app/lib/components file outside an allowlist (the Mintsoft connector, its per-connector ingress, the WMS dispatch facades/registry/panels, the UI connector registry, and cosmetic/plugin files). Per-line waiver: `// wms-connector-boundary-ok: <ticket>: <reason>`. Wired into `npm run check:all` + a new "WMS Connector Boundary Guard" CI workflow. - docs/wms-connector-boundary.md: documents the frozen contract, the dispatch facades, where the literal is allowed, and the enforcement. - Cleaned the last cosmetic leaks so the protected core surfaces are literal-free: renamed mintsoft* DOM ids in po-detail-client + transfer-list to wms*; reworded a transfers.ts comment. products.ts (product-mutation Mintsoft sync) is a genuine pending generalization — allowlisted and tracked as a follow-up (h02x.10.7). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locks in the connector-agnostic WMS boundary built across h02x.10.1–.5 (bd onetwo3d-ims-h02x.10.6) so a regression can't silently re-introduce a
mintsoftbranch into a core flow. Completes the h02x.10 epic.Changes
scripts/check-wms-connector-boundary.mjs— static guard: fails if themintsoftliteral appears in anyapp/lib/componentsfile outside an allowlist (the Mintsoft connector, its per-connector ingress, the WMS dispatch facades/registry/panels, the UI connector registry, cosmetic/plugin files). Per-line waiver:// wms-connector-boundary-ok: <ticket>: <reason>. Allowlist matching distinguishes directory prefixes (/), filename-prefixes (-), and exact files so siblings aren't over-exempted.npm run check:all+ a new WMS Connector Boundary Guard CI workflow.docs/wms-connector-boundary.md— documents the frozen contract, dispatch facades, allowed-literal locations, and enforcement.mintsoft*DOM ids →wms*inpo-detail-client+transfer-list; reworded atransfers.tscomment — so the protected core surfaces are fully literal-free.products.ts(product-mutation Mintsoft sync) is a genuine pending generalization — allowlisted + filed as follow-up h02x.10.7.Verification
npm run type-check✅ ·eslint✅ · guard green (scanned 807 files)startsWithover-match) was fixed in this PR; protected surfaces confirmed non-allowlisted and clean.🤖 Generated with Claude Code