Commit d15bb9d
committed
ci: move off the Node 20 runtime
GitHub is deprecating Node 20 and has begun forcing these actions onto Node 24
regardless, so they are already running on a runtime they do not declare.
Two actions were responsible. actions/checkout declares node20 and appears on
six steps that expand to ten job runs through the two matrices -- which is
exactly the ten warnings the last run reported. actions/deploy-pages declares
node20 on the one job that publishes. Both move to the major that adopted Node
24.
actions/upload-pages-artifact stays at v3 on purpose, and the reason is written
beside it so the next person does not finish the job. It is a composite action
with no Node runtime of its own, so it was never part of this deprecation, and
v3 alongside deploy-pages@v5 is the pairing GitHub ships in its own Pages
starter workflow. Newer majors exist; swapping a tested pairing for an untested
one to fix a problem it does not have is not an improvement.
checkout stops at v5 rather than v7 for the same reason. v6 moves credentials to
a separate file and v7 blocks fork-PR checkout for pull_request_target and
workflow_run -- neither of which this workflow uses, so v7 would be safe. v5 is
the version that fixes Node 20, and a CI file is a poor place for changes that
buy nothing.
Verified as far as it can be locally: the workflow still parses and still has
seven jobs, both target majors exist, and the runtime each action declares was
read from its own action.yml rather than assumed. Whether the actions themselves
behave is what the next run answers, and a failure would be confined to
publish-docs.1 parent ab81df2 commit d15bb9d
1 file changed
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
| |||
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
351 | 355 | | |
352 | 356 | | |
353 | 357 | | |
| |||
373 | 377 | | |
374 | 378 | | |
375 | 379 | | |
376 | | - | |
| 380 | + | |
0 commit comments